diff mbox series

ssb: chipcommon: fix fall-through annotation

Message ID 20181003120102.GA22824@embeddedor.com (mailing list archive)
State Accepted
Commit 74aa3586c59906f9b76720416aee045db2f7b3b5
Delegated to: Kalle Valo
Headers show
Series ssb: chipcommon: fix fall-through annotation | expand

Commit Message

Gustavo A. R. Silva Oct. 3, 2018, 12:01 p.m. UTC
Replace "Fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/ssb/driver_chipcommon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Büsch Oct. 3, 2018, 8:04 p.m. UTC | #1
On Wed, 3 Oct 2018 14:01:02 +0200
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> Replace "Fallthough" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/ssb/driver_chipcommon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
> index 99a4656..3861cb6 100644
> --- a/drivers/ssb/driver_chipcommon.c
> +++ b/drivers/ssb/driver_chipcommon.c
> @@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
>  			*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
>  			break;
>  		}
> -		/* Fallthough */
> +		/* Fall through */
>  	default:
>  		*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
>  	}

Acked-by: Michael Büsch <m@bues.ch>
Kalle Valo Oct. 5, 2018, 8:37 a.m. UTC | #2
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> Replace "Fallthough" with a proper "fall through" annotation.
> 
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Michael Buesch <m@bues.ch>

Patch applied to wireless-drivers-next.git, thanks.

74aa3586c599 ssb: chipcommon: fix fall-through annotation
diff mbox series

Patch

diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
index 99a4656..3861cb6 100644
--- a/drivers/ssb/driver_chipcommon.c
+++ b/drivers/ssb/driver_chipcommon.c
@@ -425,7 +425,7 @@  void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
 			*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
 			break;
 		}
-		/* Fallthough */
+		/* Fall through */
 	default:
 		*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
 	}