| Message ID | 20181008175126.82965-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | [iw] iw: fix enum warnings | expand |
On Mon, 2018-10-08 at 10:51 -0700, Brian Norris wrote: > clang warns about the misuse of enums: > > reg.c:246:26: warning: implicit conversion from enumeration type 'enum command_identify_by' to different enumeration type 'enum id_input' [-Wenum-conversion] > err = handle_cmd(state, CIB_NONE, 2, dump_args); > ~~~~~~~~~~ ^~~~~~~~ > info.c:645:26: warning: implicit conversion from enumeration type 'enum command_identify_by' to different enumeration type 'enum id_input' [-Wenum-conversion] > err = handle_cmd(state, CIB_NONE, 2, feat_args); > ~~~~~~~~~~ ^~~~~~~~ Applied, thanks. johannes
diff --git a/info.c b/info.c index fbf3ee095f9c..d0577e32552e 100644 --- a/info.c +++ b/info.c @@ -718,7 +718,7 @@ static int handle_info(struct nl80211_state *state, char *feat_args[] = { "features", "-q" }; int err; - err = handle_cmd(state, CIB_NONE, 2, feat_args); + err = handle_cmd(state, II_NONE, 2, feat_args); if (!err && nl80211_has_split_wiphy) { nla_put_flag(msg, NL80211_ATTR_SPLIT_WIPHY_DUMP); nlmsg_hdr(msg)->nlmsg_flags |= NLM_F_DUMP; diff --git a/reg.c b/reg.c index cadff3884c04..a2368df39009 100644 --- a/reg.c +++ b/reg.c @@ -243,7 +243,7 @@ static int handle_reg_get(struct nl80211_state *state, char *dump_args[] = { "reg", "dump" }; int err; - err = handle_cmd(state, CIB_NONE, 2, dump_args); + err = handle_cmd(state, II_NONE, 2, dump_args); /* * dump might fail since it's not supported on older kernels, * in that case the handler is still registered already
clang warns about the misuse of enums: reg.c:246:26: warning: implicit conversion from enumeration type 'enum command_identify_by' to different enumeration type 'enum id_input' [-Wenum-conversion] err = handle_cmd(state, CIB_NONE, 2, dump_args); ~~~~~~~~~~ ^~~~~~~~ info.c:645:26: warning: implicit conversion from enumeration type 'enum command_identify_by' to different enumeration type 'enum id_input' [-Wenum-conversion] err = handle_cmd(state, CIB_NONE, 2, feat_args); ~~~~~~~~~~ ^~~~~~~~ Signed-off-by: Brian Norris <briannorris@chromium.org> --- info.c | 2 +- reg.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)