From patchwork Fri Nov 9 05:30:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 10675305 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 559771709 for ; Fri, 9 Nov 2018 05:30:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B6152E2C1 for ; Fri, 9 Nov 2018 05:30:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2E0342E2E0; Fri, 9 Nov 2018 05:30:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SUBJ_OBFU_PUNCT_FEW, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EA012E2C1 for ; Fri, 9 Nov 2018 05:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727718AbeKIPJK (ORCPT ); Fri, 9 Nov 2018 10:09:10 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:45403 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727087AbeKIPJJ (ORCPT ); Fri, 9 Nov 2018 10:09:09 -0500 Received: by mail-oi1-f196.google.com with SMTP id p144-v6so529147oic.12; Thu, 08 Nov 2018 21:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xrcsgjlNOYa+gpPGnMn9FJzPuleKov99jbnVt5Nn8rk=; b=VOCgF7ubBnuDtjRfD0PwT9jqP0BSO+3I2IJI3GSgUoi2Aw7yMJXtnHSwb2ngGRWw70 KjnuWiWAkHX0GTYJ+NRx5lU09KfT8ZE+Sd4v5ANhJJRdEyvCSEN2qdD+9DQY8seHxWI9 Mq0wgSSd53GysKEdss5wm0CeFCHJdVoQ6oB/tcxOFsTxxqSK4vCGvBOWm7jCRejVDjEf G5dIKfBPLtSgCqB8GzYaZhMJvdgDfPeynwI1Bg3H0+E3rHb4ApjPph5nHU2Y4y6WG9iM fvDALGdgSnoOoEuKQAnG45bEAzCtP7nPtu/aPMC78vcNiKIhWV79oDJkPnvRPiwmk91C EVjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=xrcsgjlNOYa+gpPGnMn9FJzPuleKov99jbnVt5Nn8rk=; b=aspQ6I+hcA4mxFaY0BZaSy5cUlIXASLjqU/2CXzWOjKA/MtZww2NNHvhMTNnWX0grk LUIWGx4GJHooFVw5bJTHnk2AlqaVRfpWa8OMUDc01cTzYzOX/M4xuCqkdSqFjjT6/Cud 8aPJItl4J3Jmc1zjZ3ZLE1nCByKrC+DDwG1v5kU+Kh+sT49PsPXWheP1rP2hHW17txe9 FGy+MRdklVAJj4ETXcodCJTUlHhGJz055CRhrE+yd3Izhb1fliKWfK0xt1lPqlLZPP8W BnQNt/83kUiiTDyC8QcjEvvSZv3rj4eAIR7G5kteWyoICHCSIHmbOV6vZZ8sy0RZGI8k AzmA== X-Gm-Message-State: AGRZ1gJHgWit7jr9FJIW9AZg0aVc2a9L+Y7TqYLImgjcaCzg7SeIdkGS oNEAZz+5O7fUilDZ9SN4mDw= X-Google-Smtp-Source: AJdET5cJ5rR7+0jR4apyuh1n5xU+Q/YyUcdpcfRX+/9faHGWDMkVvXNOlUj4fUctjcjo2l4ZOEhQZg== X-Received: by 2002:aca:4d95:: with SMTP id a143-v6mr4436797oib.343.1541741414095; Thu, 08 Nov 2018 21:30:14 -0800 (PST) Received: from localhost.localdomain (cpe-24-31-245-230.kc.res.rr.com. [24.31.245.230]) by smtp.gmail.com with ESMTPSA id p204-v6sm2751373oib.25.2018.11.08.21.30.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 21:30:13 -0800 (PST) From: Larry Finger To: gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , linux-wireless@vger.kernel.org, youling257 Subject: [PATCH] staging: rtl8723bs: Add missing return for cfg80211_rtw_get_station Date: Thu, 8 Nov 2018 23:30:09 -0600 Message-Id: <20181109053009.26055-1-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With Androidx86 8.1, wificond returns "failed to get nl80211_sta_info_tx_failed" and wificondControl returns "Invalid signal poll result from wificond". The fix is to OR sinfo->filled with BIT_ULL(NL80211_STA_INFO_TX_FAILED). This missing bit is apparently not needed with NetworkManager, but it does no harm in that case. Reported-and-Tested-by: youling257 Cc: linux-wireless@vger.kernel.org Cc: youling257 Signed-off-by: Larry Finger --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index af2234798fa8..db553f2e4c0b 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1277,7 +1277,7 @@ static int cfg80211_rtw_get_station(struct wiphy *wiphy, sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_PACKETS); sinfo->tx_packets = psta->sta_stats.tx_pkts; - + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_FAILED); } /* for Ad-Hoc/AP mode */