| Message ID | 20190117143623.29363-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b0535d502d1804197f3aaaaf5a3429c5779268e4 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | cw1200: fix indentation issues | expand |
Colin King <colin.king@canonical.com> writes: > From: Colin Ian King <colin.king@canonical.com> > > There are two lines that have indentation issues, fix these. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/wireless/st/cw1200/fwio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c > index 30e7646d04af..b7881232499c 100644 > --- a/drivers/net/wireless/st/cw1200/fwio.c > +++ b/drivers/net/wireless/st/cw1200/fwio.c > @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv) > > if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) { > pr_err("Device is already in QUEUE mode!\n"); > - ret = -EINVAL; > - goto out; > + ret = -EINVAL; > + goto out; Just out of curiosity, how do you find these?
On 17/01/2019 14:54, Kalle Valo wrote: > Colin King <colin.king@canonical.com> writes: > >> From: Colin Ian King <colin.king@canonical.com> >> >> There are two lines that have indentation issues, fix these. >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/net/wireless/st/cw1200/fwio.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c >> index 30e7646d04af..b7881232499c 100644 >> --- a/drivers/net/wireless/st/cw1200/fwio.c >> +++ b/drivers/net/wireless/st/cw1200/fwio.c >> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv) >> >> if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) { >> pr_err("Device is already in QUEUE mode!\n"); >> - ret = -EINVAL; >> - goto out; >> + ret = -EINVAL; >> + goto out; > > Just out of curiosity, how do you find these? > smatch, grep for "warn: inconsistent indenting" Colin
Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are two lines that have indentation issues, fix these. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied to wireless-drivers-next.git, thanks. b0535d502d18 cw1200: fix indentation issues
diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c index 30e7646d04af..b7881232499c 100644 --- a/drivers/net/wireless/st/cw1200/fwio.c +++ b/drivers/net/wireless/st/cw1200/fwio.c @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv) if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) { pr_err("Device is already in QUEUE mode!\n"); - ret = -EINVAL; - goto out; + ret = -EINVAL; + goto out; } switch (priv->hw_type) {