| Message ID | 20190128223111.19400-1-adham.abozaeid@microchip.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/1] staging: wilc1000: remove redundant reset of station statistics | expand |
On Mon, Jan 28, 2019 at 10:38:20PM +0000, Adham.Abozaeid@microchip.com wrote: > From: Adham Abozaeid <adham.abozaeid@microchip.com> > > Driver sends configuration wids to reset connection statistics in the > device, but the device already resets it when starting a new connection > > Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com> > --- > drivers/staging/wilc1000/host_interface.c | 20 +------------------- > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > index fbb61de20304..286685e426c1 100644 > --- a/drivers/staging/wilc1000/host_interface.c > +++ b/drivers/staging/wilc1000/host_interface.c > @@ -342,29 +342,11 @@ static int wilc_send_connect_wid(struct wilc_vif *vif) > { > int result = 0; > struct wid wid_list[8]; ^^^^^^^^^^^ We could make this array smaller as well. > - u32 wid_cnt = 0, dummyval = 0; > + u32 wid_cnt = 0; regards, dan carpenter
On 1/29/19 1:39 AM, Dan Carpenter wrote: > On Mon, Jan 28, 2019 at 10:38:20PM +0000, Adham.Abozaeid@microchip.com wrote: >> From: Adham Abozaeid <adham.abozaeid@microchip.com> >> >> Driver sends configuration wids to reset connection statistics in the >> device, but the device already resets it when starting a new connection >> >> Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com> >> --- >> drivers/staging/wilc1000/host_interface.c | 20 +------------------- >> 1 file changed, 1 insertion(+), 19 deletions(-) >> >> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c >> index fbb61de20304..286685e426c1 100644 >> --- a/drivers/staging/wilc1000/host_interface.c >> +++ b/drivers/staging/wilc1000/host_interface.c >> @@ -342,29 +342,11 @@ static int wilc_send_connect_wid(struct wilc_vif *vif) >> { >> int result = 0; >> struct wid wid_list[8]; > ^^^^^^^^^^^ > We could make this array smaller as well. Agree. Will send v2 with smaller array. > >> - u32 wid_cnt = 0, dummyval = 0; >> + u32 wid_cnt = 0; > regards, > dan carpenter Thanks, Adham
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index fbb61de20304..286685e426c1 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -342,29 +342,11 @@ static int wilc_send_connect_wid(struct wilc_vif *vif) { int result = 0; struct wid wid_list[8]; - u32 wid_cnt = 0, dummyval = 0; + u32 wid_cnt = 0; struct host_if_drv *hif_drv = vif->hif_drv; struct wilc_conn_info *conn_attr = &hif_drv->conn_info; struct wilc_join_bss_param *bss_param = conn_attr->param; - wid_list[wid_cnt].id = WID_SUCCESS_FRAME_COUNT; - wid_list[wid_cnt].type = WID_INT; - wid_list[wid_cnt].size = sizeof(u32); - wid_list[wid_cnt].val = (s8 *)(&(dummyval)); - wid_cnt++; - - wid_list[wid_cnt].id = WID_RECEIVED_FRAGMENT_COUNT; - wid_list[wid_cnt].type = WID_INT; - wid_list[wid_cnt].size = sizeof(u32); - wid_list[wid_cnt].val = (s8 *)(&(dummyval)); - wid_cnt++; - - wid_list[wid_cnt].id = WID_FAILED_COUNT; - wid_list[wid_cnt].type = WID_INT; - wid_list[wid_cnt].size = sizeof(u32); - wid_list[wid_cnt].val = (s8 *)(&(dummyval)); - wid_cnt++; - wid_list[wid_cnt].id = WID_INFO_ELEMENT_ASSOCIATE; wid_list[wid_cnt].type = WID_BIN_DATA; wid_list[wid_cnt].val = conn_attr->req_ies;