| Message ID | 20190404134723.24667-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e643da21e19a62f928fb30f080470ea2e335b7f0 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath6kl: remove redundant check of status != 0 | expand |
Colin King <colin.king@canonical.com> writes: > From: Colin Ian King <colin.king@canonical.com> > > The check on status not being zero is redundant as previous code > paths that set status to an error value break out of the while > loop and hence status is never non-zero at the check. Remove > this redundant code. > > Addresses-Coverity: ("Logically dead code") Is the coverity id missing?
On 4/4/2019 7:17 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The check on status not being zero is redundant as previous code > paths that set status to an error value break out of the while > loop and hence status is never non-zero at the check. Remove > this redundant code. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cheers, -Mukesh > --- > drivers/net/wireless/ath/ath6kl/htc_pipe.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c > index 434b66829646..c68848819a52 100644 > --- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c > +++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c > @@ -898,9 +898,6 @@ static int htc_process_trailer(struct htc_target *target, u8 *buffer, > break; > } > > - if (status != 0) > - break; > - > /* advance buffer past this record for next time around */ > buffer += record->len; > len -= record->len;
Colin King <colin.king@canonical.com> wrote: > The check on status not being zero is redundant as previous code > paths that set status to an error value break out of the while > loop and hence status is never non-zero at the check. Remove > this redundant code. > > Addresses-Coverity: ("Logically dead code") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. e643da21e19a ath6kl: remove redundant check of status != 0
diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c index 434b66829646..c68848819a52 100644 --- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c +++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c @@ -898,9 +898,6 @@ static int htc_process_trailer(struct htc_target *target, u8 *buffer, break; } - if (status != 0) - break; - /* advance buffer past this record for next time around */ buffer += record->len; len -= record->len;