| Message ID | 20190412213710.17292-1-greearb@candelatech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | [1/2] wireless: Support auth-at-ms timer in sta-info | expand |
On Fri, 2019-04-12 at 14:37 -0700, greearb@candelatech.com wrote: > From: Ben Greear <greearb@candelatech.com> > > Report time stamp of when sta became authenticated. You didn't actually implement this ;-) Did you mean associated? > + * @auth_at_ms: time in ms of the last assoc -> auth transition. There's commonly not really such a transition? johannes
On 4/15/19 4:15 AM, Johannes Berg wrote: > On Fri, 2019-04-12 at 14:37 -0700, greearb@candelatech.com wrote: >> From: Ben Greear <greearb@candelatech.com> >> >> Report time stamp of when sta became authenticated. > > You didn't actually implement this ;-) > > Did you mean associated? > >> + * @auth_at_ms: time in ms of the last assoc -> auth transition. > > There's commonly not really such a transition? Oh, I guess AUTHORIZED is only when doing .1x authentication? My test case was (luckly?) doing that, so I didn't notice the bug. I'll change to setting the timer in the ASSOC state instead. Thanks, Ben
On Mon, 2019-04-15 at 09:32 -0700, Ben Greear wrote: > On 4/15/19 4:15 AM, Johannes Berg wrote: > > On Fri, 2019-04-12 at 14:37 -0700, greearb@candelatech.com wrote: > > > From: Ben Greear <greearb@candelatech.com> > > > > > > Report time stamp of when sta became authenticated. > > > > You didn't actually implement this ;-) > > > > Did you mean associated? > > > > > + * @auth_at_ms: time in ms of the last assoc -> auth transition. > > > > There's commonly not really such a transition? > > Oh, I guess AUTHORIZED is only when doing .1x authentication? My test case > was (luckly?) doing that, so I didn't notice the bug. Oh, you meant *authorized*... Most of the code uses "auth" == "authenticated" :-) johannes
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index f49eb1464b7a..430501c09c01 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -1268,6 +1268,7 @@ struct cfg80211_tid_stats { * indicate the relevant values in this struct for them * @connected_time: time(in secs) since a station is last connected * @inactive_time: time since last station activity (tx/rx) in milliseconds + * @auth_at_ms: time in ms of the last assoc -> auth transition. * @rx_bytes: bytes (size of MPDUs) received from this station * @tx_bytes: bytes (size of MPDUs) transmitted to this station * @llid: mesh local link id @@ -1324,6 +1325,7 @@ struct station_info { u64 filled; u32 connected_time; u32 inactive_time; + u64 auth_at_ms; u64 rx_bytes; u64 tx_bytes; u16 llid; diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index 0f03cfcda965..8d0b7a88877c 100644 --- a/include/uapi/linux/nl80211.h +++ b/include/uapi/linux/nl80211.h @@ -3079,6 +3079,7 @@ enum nl80211_sta_bss_param { * @NL80211_STA_INFO_TX_DURATION: aggregate PPDU duration for all frames * sent to the station (u64, usec) * @NL80211_STA_INFO_AIRTIME_WEIGHT: current airtime weight for station (u16) + * @NL80211_STA_INFO_AUTH_AT_MS: Timestamp of last assoc -> auth transition, in ms * @__NL80211_STA_INFO_AFTER_LAST: internal * @NL80211_STA_INFO_MAX: highest possible station info attribute */ @@ -3124,6 +3125,7 @@ enum nl80211_sta_info { NL80211_STA_INFO_CONNECTED_TO_GATE, NL80211_STA_INFO_TX_DURATION, NL80211_STA_INFO_AIRTIME_WEIGHT, + NL80211_STA_INFO_AUTH_AT_MS, /* keep last */ __NL80211_STA_INFO_AFTER_LAST, diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index bcb432815c64..74be48c1ae02 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -4763,6 +4763,7 @@ static int nl80211_send_station(struct sk_buff *msg, u32 cmd, u32 portid, PUT_SINFO(CONNECTED_TIME, connected_time, u32); PUT_SINFO(INACTIVE_TIME, inactive_time, u32); + PUT_SINFO_U64(AUTH_AT_MS, auth_at_ms); if (sinfo->filled & (BIT_ULL(NL80211_STA_INFO_RX_BYTES) | BIT_ULL(NL80211_STA_INFO_RX_BYTES64)) &&