| Message ID | 20190530184044.8479-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5315f9d40191f98abcd3164e632a8a8f737b1cf0 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: remove redundant assignment to variable badworden | expand |
On 5/30/19 1:40 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable badworden is assigned with a value that is never read and > it is re-assigned a new value immediately afterwards. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Thanks, Larry > drivers/net/wireless/realtek/rtlwifi/efuse.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c > index e68340dfd980..37ab582a8afb 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c > +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c > @@ -986,7 +986,6 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw, > } else if (write_state == PG_STATE_DATA) { > RTPRINT(rtlpriv, FEEPROM, EFUSE_PG, > "efuse PG_STATE_DATA\n"); > - badworden = 0x0f; > badworden = > enable_efuse_data_write(hw, efuse_addr + 1, > target_pkt.word_en, >
Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable badworden is assigned with a value that is never read and > it is re-assigned a new value immediately afterwards. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Acked-by: Larry Finger <Larry.Finger@lwfinger.net> Patch applied to wireless-drivers-next.git, thanks. 5315f9d40191 rtlwifi: remove redundant assignment to variable badworden
diff --git a/drivers/net/wireless/realtek/rtlwifi/efuse.c b/drivers/net/wireless/realtek/rtlwifi/efuse.c index e68340dfd980..37ab582a8afb 100644 --- a/drivers/net/wireless/realtek/rtlwifi/efuse.c +++ b/drivers/net/wireless/realtek/rtlwifi/efuse.c @@ -986,7 +986,6 @@ static int efuse_pg_packet_write(struct ieee80211_hw *hw, } else if (write_state == PG_STATE_DATA) { RTPRINT(rtlpriv, FEEPROM, EFUSE_PG, "efuse PG_STATE_DATA\n"); - badworden = 0x0f; badworden = enable_efuse_data_write(hw, efuse_addr + 1, target_pkt.word_en,