Message ID | 20190604173144.109142-1-briannorris@chromium.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 2fc0aa454473a5f528cdc3e357da4489d0ccc6ee |
Delegated to: | Kalle Valo |
Headers | show |
Series | mwifiex: print PCI mmap with %pK | expand |
Brian Norris <briannorris@chromium.org> wrote: > Unadorned '%p' has restrictive policies these days, such that it usually > just prints garbage at early boot (see > Documentation/core-api/printk-formats.rst, "kernel will print > ``(ptrval)`` until it gathers enough entropy"). Annotating with %pK > (for "kernel pointer") allows the kptr_restrict sysctl to control > printing policy better. > > We might just as well drop this message entirely, but this fix was easy > enough for now. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-drivers-next.git, thanks. 2fc0aa454473 mwifiex: print PCI mmap with %pK
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c index 82f58bf0fc43..b54f73e3d508 100644 --- a/drivers/net/wireless/marvell/mwifiex/pcie.c +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c @@ -2959,7 +2959,7 @@ static int mwifiex_init_pcie(struct mwifiex_adapter *adapter) goto err_iomap2; } - pr_notice("PCI memory map Virt0: %p PCI memory map Virt2: %p\n", + pr_notice("PCI memory map Virt0: %pK PCI memory map Virt2: %pK\n", card->pci_mmap, card->pci_mmap1); ret = mwifiex_pcie_alloc_buffers(adapter);
Unadorned '%p' has restrictive policies these days, such that it usually just prints garbage at early boot (see Documentation/core-api/printk-formats.rst, "kernel will print ``(ptrval)`` until it gathers enough entropy"). Annotating with %pK (for "kernel pointer") allows the kptr_restrict sysctl to control printing policy better. We might just as well drop this message entirely, but this fix was easy enough for now. Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)