| Message ID | 20190812192741.14479-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 01bb31de526265e51e21e3efcdcbbe7e6906b051 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | None | expand |
Larry Finger <Larry.Finger@lwfinger.net> wrote: > In the process of converting the bit manipulation macros were converted > to use GENMASK(), the compiler reported a value too big for the field. > The offending statement was trying to write 0x100 into a 5-bit field. > An accompaning comment says to set bit 3, thus the code is changed > appropriately. > > This error has been in the driver since its initial submission. > > Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx") > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> I only see patch 5 on patchwork, what happened to patches 1-4?
On 8/20/19 9:08 AM, Kalle Valo wrote: > Larry Finger <Larry.Finger@lwfinger.net> wrote: > >> In the process of converting the bit manipulation macros were converted >> to use GENMASK(), the compiler reported a value too big for the field. >> The offending statement was trying to write 0x100 into a 5-bit field. >> An accompaning comment says to set bit 3, thus the code is changed >> appropriately. >> >> This error has been in the driver since its initial submission. >> >> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx") >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > > I only see patch 5 on patchwork, what happened to patches 1-4? I pulled them at the last minute, but forgot to rename the subject. Please apply that fix alone. The others will follow when I get time; however, they are code improvements. Only this one was a code fix. Larry
Larry Finger <Larry.Finger@lwfinger.net> writes: > On 8/20/19 9:08 AM, Kalle Valo wrote: >> Larry Finger <Larry.Finger@lwfinger.net> wrote: >> >>> In the process of converting the bit manipulation macros were converted >>> to use GENMASK(), the compiler reported a value too big for the field. >>> The offending statement was trying to write 0x100 into a 5-bit field. >>> An accompaning comment says to set bit 3, thus the code is changed >>> appropriately. >>> >>> This error has been in the driver since its initial submission. >>> >>> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx") >>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> >> >> I only see patch 5 on patchwork, what happened to patches 1-4? > > I pulled them at the last minute, but forgot to rename the subject. > Please apply that fix alone. The others will follow when I get time; > however, they are code improvements. Only this one was a code fix. Ok, I was just worried if patchwork had lost of them somehow.
Larry Finger <Larry.Finger@lwfinger.net> wrote: > In the process of converting the bit manipulation macros were converted > to use GENMASK(), the compiler reported a value too big for the field. > The offending statement was trying to write 0x100 into a 5-bit field. > An accompaning comment says to set bit 3, thus the code is changed > appropriately. > > This error has been in the driver since its initial submission. > > Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx") > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Patch applied to wireless-drivers-next.git, thanks. 01bb31de5262 rtlwifi: rtl8192cu: Fix value set in descriptor
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c index 0020adc004a5..9b5c7ec6b6f7 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c @@ -611,7 +611,7 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 *pdesc, SET_TX_DESC_NAV_USE_HDR(pdesc, 1); } else { SET_TX_DESC_HWSEQ_EN(pdesc, 1); /* Hw set sequence number */ - SET_TX_DESC_PKT_ID(pdesc, 0x100); /* set bit3 to 1. */ + SET_TX_DESC_PKT_ID(pdesc, BIT(3)); /* set bit3 to 1. */ } SET_TX_DESC_USE_RATE(pdesc, 1); /* use data rate which is set by Sw */ SET_TX_DESC_OWN(pdesc, 1);
In the process of converting the bit manipulation macros were converted to use GENMASK(), the compiler reported a value too big for the field. The offending statement was trying to write 0x100 into a 5-bit field. An accompaning comment says to set bit 3, thus the code is changed appropriately. This error has been in the driver since its initial submission. Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx") Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)