| Message ID | 20191023075342.26656-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4fcef86091327d92008ca0328d45075343e7edea |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtl8xxxu: remove set but not used variable 'rate_mask' | expand |
On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@huawei.com> wrote: > > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6: > warning: variable rate_mask set but not used [-Wunused-but-set-variable] > > It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve > TX performance of RTL8723BU on rtl8xxxu driver") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- Singed-off-by: Chris Chiu <chiu@endlessm.com> > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > index 1e3b716..3843d7a 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > @@ -4481,11 +4481,6 @@ static u16 > rtl8xxxu_wireless_mode(struct ieee80211_hw *hw, struct ieee80211_sta *sta) > { > u16 network_type = WIRELESS_MODE_UNKNOWN; > - u32 rate_mask; > - > - rate_mask = (sta->supp_rates[0] & 0xfff) | > - (sta->ht_cap.mcs.rx_mask[0] << 12) | > - (sta->ht_cap.mcs.rx_mask[0] << 20); > > if (hw->conf.chandef.chan->band == NL80211_BAND_5GHZ) { > if (sta->vht_cap.vht_supported) > -- > 2.7.4 Thanks for pointing that out. Chris
Chris Chiu <chiu@endlessm.com> writes: > On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6: >> warning: variable rate_mask set but not used [-Wunused-but-set-variable] >> >> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve >> TX performance of RTL8723BU on rtl8xxxu driver") >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- > Singed-off-by: Chris Chiu <chiu@endlessm.com> In the future please use Reviewed-by: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes Signed-off-by is supposed to be used when you are sending a patch and Acked-by is used by the driver maintainer, in this case Jes.
YueHaibing <yuehaibing@huawei.com> wrote: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6: > warning: variable rate_mask set but not used [-Wunused-but-set-variable] > > It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve > TX performance of RTL8723BU on rtl8xxxu driver") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 4fcef8609132 rtl8xxxu: remove set but not used variable 'rate_mask'
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 1e3b716..3843d7a 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -4481,11 +4481,6 @@ static u16 rtl8xxxu_wireless_mode(struct ieee80211_hw *hw, struct ieee80211_sta *sta) { u16 network_type = WIRELESS_MODE_UNKNOWN; - u32 rate_mask; - - rate_mask = (sta->supp_rates[0] & 0xfff) | - (sta->ht_cap.mcs.rx_mask[0] << 12) | - (sta->ht_cap.mcs.rx_mask[0] << 20); if (hw->conf.chandef.chan->band == NL80211_BAND_5GHZ) { if (sta->vht_cap.vht_supported)
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6: warning: variable rate_mask set but not used [-Wunused-but-set-variable] It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve TX performance of RTL8723BU on rtl8xxxu driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 ----- 1 file changed, 5 deletions(-)