diff mbox series

[1/2] rtw88: fix sparse warnings for DPK

Message ID 20191025083200.20245-2-yhchuang@realtek.com (mailing list archive)
State Accepted
Commit 1f592108bbd0c7eecfb0e60fd8f6690e134dc254
Delegated to: Kalle Valo
Headers show
Series rtw88: fix sparse warnings | expand

Commit Message

Tony Chuang Oct. 25, 2019, 8:31 a.m. UTC 
From: Yan-Hsuan Chuang <yhchuang@realtek.com>

sparse warnings:
    drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse:
sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be
static?
    drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse:
sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be
static?

Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/rtw8822c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Oct. 31, 2019, 8:03 a.m. UTC | #1 
<yhchuang@realtek.com> wrote:

> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> 
> sparse warnings:
>     drivers/net/wireless/realtek/rtw88/rtw8822c.c:2871:6: sparse:
> sparse: symbol 'rtw8822c_dpk_cal_coef1' was not declared. Should it be
> static?
>     drivers/net/wireless/realtek/rtw88/rtw8822c.c:3112:6: sparse:
> sparse: symbol 'rtw8822c_dpk_track' was not declared. Should it be
> static?
> 
> Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>

2 patches applied to wireless-drivers-next.git, thanks.

1f592108bbd0 rtw88: fix sparse warnings for DPK
a969cf42e5fe rtw88: fix sparse warnings for power tracking
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index b77905196ffb..97f4c4e1d7e9 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -2970,7 +2970,7 @@  static void rtw8822c_dpk_cal_gs(struct rtw_dev *rtwdev, u8 path)
 	dpk_info->dpk_gs[path] = tmp_gs;
 }
 
-void rtw8822c_dpk_cal_coef1(struct rtw_dev *rtwdev)
+static void rtw8822c_dpk_cal_coef1(struct rtw_dev *rtwdev)
 {
 	struct rtw_dpk_info *dpk_info = &rtwdev->dm_info.dpk_info;
 	u32 offset[DPK_RF_PATH_NUM] = {0, 0x58};
@@ -3211,7 +3211,7 @@  static void rtw8822c_phy_calibration(struct rtw_dev *rtwdev)
 	rtw8822c_do_dpk(rtwdev);
 }
 
-void rtw8822c_dpk_track(struct rtw_dev *rtwdev)
+static void rtw8822c_dpk_track(struct rtw_dev *rtwdev)
 {
 	struct rtw_dpk_info *dpk_info = &rtwdev->dm_info.dpk_info;
 	u8 path;