diff mbox series

[next] rtw88: remove redundant null pointer check on arrays

Message ID 20191025113056.19167-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit baff8da6e1636420ce04cadd6df56e137fa6e005
Delegated to: Kalle Valo
Headers show
Series [next] rtw88: remove redundant null pointer check on arrays | expand

Commit Message

Colin King Oct. 25, 2019, 11:30 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The checks to see if swing_table->n or swing_table->p are null are
redundant since n and p are arrays and can never be null if
swing_table is non-null.  I believe these are redundant checks
and can be safely removed, especially the checks implies that these
are not arrays which can lead to confusion.

Addresses-Coverity: ("Array compared against 0")
Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/realtek/rtw88/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Oct. 31, 2019, 8:05 a.m. UTC | #1 
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The checks to see if swing_table->n or swing_table->p are null are
> redundant since n and p are arrays and can never be null if
> swing_table is non-null.  I believe these are redundant checks
> and can be safely removed, especially the checks implies that these
> are not arrays which can lead to confusion.
> 
> Addresses-Coverity: ("Array compared against 0")
> Fixes: c97ee3e0bea2 ("rtw88: add power tracking support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied to wireless-drivers-next.git, thanks.

baff8da6e163 rtw88: remove redundant null pointer check on arrays
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
index 69e7edb629f4..11893ec73376 100644
--- a/drivers/net/wireless/realtek/rtw88/phy.c
+++ b/drivers/net/wireless/realtek/rtw88/phy.c
@@ -2071,7 +2071,7 @@  s8 rtw_phy_pwrtrack_get_pwridx(struct rtw_dev *rtwdev,
 		return 0;
 	}
 
-	if (!swing_table || !swing_table->n || !swing_table->p) {
+	if (!swing_table) {
 		rtw_warn(rtwdev, "swing table not configured\n");
 		return 0;
 	}