| Message ID | 20191210143417.142964-1-toke@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | mac80211: Always show airtime debugfs file when TXQs are enabled | expand |
Toke Høiland-Jørgensen <toke@redhat.com> writes: > The AQL statistics are displayed in the 'airtime' station debugfs file, but > that file was only shown if a driver has enabled the airtime fairness > feature flag. Since AQL can be enabled without airtime fairness, let's > expose the airtime file whenever TXQs are enabled, so the AQL data can be > read. > > Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> With the change to an NL80211_EXT_FEATURE for AQL, this is no longer needed, so please drop this patch. -Toke
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c index b3c9001d1f43..c190c29fe0dd 100644 --- a/net/mac80211/debugfs_sta.c +++ b/net/mac80211/debugfs_sta.c @@ -989,12 +989,10 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta) DEBUGFS_ADD_COUNTER(rx_fragments, rx_stats.fragments); DEBUGFS_ADD_COUNTER(tx_filtered, status_stats.filtered); - if (local->ops->wake_tx_queue) + if (local->ops->wake_tx_queue) { DEBUGFS_ADD(aqm); - - if (wiphy_ext_feature_isset(local->hw.wiphy, - NL80211_EXT_FEATURE_AIRTIME_FAIRNESS)) DEBUGFS_ADD(airtime); + } debugfs_create_xul("driver_buffered_tids", 0400, sta->debugfs_dir, &sta->driver_buffered_tids);
The AQL statistics are displayed in the 'airtime' station debugfs file, but that file was only shown if a driver has enabled the airtime fairness feature flag. Since AQL can be enabled without airtime fairness, let's expose the airtime file whenever TXQs are enabled, so the AQL data can be read. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> --- net/mac80211/debugfs_sta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)