diff mbox series

[V2,1/2] ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd()

Message ID 20191213153457.11946-1-john@phrozen.org (mailing list archive)
State Accepted
Commit 485add35771b07e56833cff77e07936ba78e731c
Delegated to: Kalle Valo
Headers show
Series [V2,1/2] ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd() | expand

Commit Message

John Crispin Dec. 13, 2019, 3:34 p.m. UTC 
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>

The code currently uses the wrong pdev id when enabling TWT. Fix this by
using the correct ones.

Fixes: e65a616f4e74 ("ath11k: add TWT support")
Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/mac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Dec. 18, 2019, 5:42 p.m. UTC | #1 
John Crispin <john@phrozen.org> wrote:

> The code currently uses the wrong pdev id when enabling TWT. Fix this by
> using the correct ones.
> 
> Fixes: e65a616f4e74 ("ath11k: add TWT support")
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

2 patches applied to ath-next branch of ath.git, thanks.

485add35771b ath11k: fix pdev when invoking ath11k_wmi_send_twt_enable_cmd()
aacb46223e08 ath11k: set the BA buffer size to 256 when HE is enabled
Kalle Valo Dec. 18, 2019, 6:06 p.m. UTC | #2 
John Crispin <john@phrozen.org> writes:

> From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
>
> The code currently uses the wrong pdev id when enabling TWT. Fix this by
> using the correct ones.
>
> Fixes: e65a616f4e74 ("ath11k: add TWT support")
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>

I noticed only after I applied this, but the s-o-b line is in wrong
order. Pradeep, being the author, should have his s-o-b line first.
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index fec268b9b711..b229b0b3e0bd 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -1917,9 +1917,9 @@  static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
 
 	if (changed & BSS_CHANGED_TWT) {
 		if (info->twt_requester || info->twt_responder)
-			ath11k_wmi_send_twt_enable_cmd(ar, ar->pdev_idx);
+			ath11k_wmi_send_twt_enable_cmd(ar, ar->pdev->pdev_id);
 		else
-			ath11k_wmi_send_twt_disable_cmd(ar, ar->pdev_idx);
+			ath11k_wmi_send_twt_disable_cmd(ar, ar->pdev->pdev_id);
 		if (vif->type == NL80211_IFTYPE_AP)
 			ath11k_debugfs_twt(arvif, info->twt_requester);
 	}