| Message ID | 20191216170302.29543-26-Jerome.Pouiller@silabs.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | Improve wfx driver | expand |
On Mon, Dec 16, 2019 at 05:03:46PM +0000, Jérôme Pouiller wrote: > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > The original name did not make any sense. > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > --- > drivers/staging/wfx/hif_api_cmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h > index 3e77fbe3d5ff..4ce3bb51cf04 100644 > --- a/drivers/staging/wfx/hif_api_cmd.h > +++ b/drivers/staging/wfx/hif_api_cmd.h > @@ -188,7 +188,7 @@ struct hif_req_start_scan { > u8 ssid_and_channel_lists[]; > } __packed; > > -struct hif_start_scan_req_cstnbssid_body { > +struct hif_req_start_scan_alt { > u8 band; > struct hif_scan_type scan_type; > struct hif_scan_flags scan_flags; Why not just delete this if it isn't used? regards, dan carpenter
On Friday 3 January 2020 10:27:44 CET Dan Carpenter wrote: > On Mon, Dec 16, 2019 at 05:03:46PM +0000, Jérôme Pouiller wrote: > > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > The original name did not make any sense. > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > --- > > drivers/staging/wfx/hif_api_cmd.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h > > index 3e77fbe3d5ff..4ce3bb51cf04 100644 > > --- a/drivers/staging/wfx/hif_api_cmd.h > > +++ b/drivers/staging/wfx/hif_api_cmd.h > > @@ -188,7 +188,7 @@ struct hif_req_start_scan { > > u8 ssid_and_channel_lists[]; > > } __packed; > > > > -struct hif_start_scan_req_cstnbssid_body { > > +struct hif_req_start_scan_alt { > > u8 band; > > struct hif_scan_type scan_type; > > struct hif_scan_flags scan_flags; > > Why not just delete this if it isn't used? Patch 47/55 start to use it. However, since patch 47, struct hif_req_start_scan is no more used. There is an item in TODO file about this: hif_api_*.h have been imported from firmware code. Some of the structures are never used in driver.
diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h index 3e77fbe3d5ff..4ce3bb51cf04 100644 --- a/drivers/staging/wfx/hif_api_cmd.h +++ b/drivers/staging/wfx/hif_api_cmd.h @@ -188,7 +188,7 @@ struct hif_req_start_scan { u8 ssid_and_channel_lists[]; } __packed; -struct hif_start_scan_req_cstnbssid_body { +struct hif_req_start_scan_alt { u8 band; struct hif_scan_type scan_type; struct hif_scan_flags scan_flags;