From patchwork Mon Dec 16 17:03:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 11294721 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6CE981580 for ; Mon, 16 Dec 2019 17:05:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A6AA206D7 for ; Mon, 16 Dec 2019 17:05:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="oSuaK0e2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726940AbfLPRFg (ORCPT ); Mon, 16 Dec 2019 12:05:36 -0500 Received: from mail-eopbgr680072.outbound.protection.outlook.com ([40.107.68.72]:26598 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726928AbfLPRDv (ORCPT ); Mon, 16 Dec 2019 12:03:51 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZTAo/LEjQWEfXacyUS6J+cCVZQfnYh65mP/wExnSHWd/4jZpEUwnMD7YGezUb3VeiN7v/W3y2lrib/BzMDxILVTbga/BMBxz9jfbWmIFy4Pu2LuDQ9+vt3MGjNQc/jaChCCn9zYiR8puGvB69UyDtMpXOEKnHcg2oKDfX1TjKOa7kCm+qxX2wDqGMjO84bM2x3ktKYbPcKFRTRaqBxRGTVXgPJfpk5TsXBDwnBUTVckTE4H1/0hL5rsVymVXp6zfjfSVKA3Fj5IXGWLwXaVfK8uLKiC8egvPp+1n+hdQCNly1vpmnrAr6gH0e/lcUk7TLUVMDuXyxuGjjeT1xWjVOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wDXzS1wnUOS9jXARYXqk0G1y1U7273hCzGnbdKeTfs=; b=m/PfVRgDyxvxRNmIGGNR7hO8sUrdMDFZ0DT7Z2MSXJD6q8+aphed5rYp73aJ2cwDq2CNc2DlPYmvnL/yw9jSN1MJGcZl9JxtXFixMH6iWHIhuj21qVla7+jxy/T7C2FoZ9wGaDCgqvUGnz1J3sV4Va8oHBcd8B3AauZrCR5BE7TRJk6OQbZXCQCBC4A5YpqyNh032ipmXGD5HOkyDyAkyjSH9H0aw90GJUfodcZSFGJ18JDkxkgBMlYdlUlcD+3Ygfq8qyseuIyXpKhcgquhmHXggtc2th/E+yTZdclNKjkfw/t+9UDq9nI8w7fLe2K4epqfSjlaOfP5nGnvzZy0Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6wDXzS1wnUOS9jXARYXqk0G1y1U7273hCzGnbdKeTfs=; b=oSuaK0e2+/3D7AYhF07Ku87giLB3x0FDbdKuKm4aUrFXvDD9LzRwhWIob5w5nIbKRy0xGMRm0HWeK5sfqbrYfU4PjfSa61qaPLG6kE2YfopC066ayj9EGtMB2pk4Mvxyb0SDiKNjYLvldljvPI5hvrI+JIjLc6r/7yGIgKvELTQ= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3838.namprd11.prod.outlook.com (20.178.252.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.19; Mon, 16 Dec 2019 17:03:44 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:03:44 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 08/55] staging: wfx: detect race condition in WEP authentication Thread-Topic: [PATCH 08/55] staging: wfx: detect race condition in WEP authentication Thread-Index: AQHVtDLBG/NDZpdpMkuP9QWA66ue4w== Date: Mon, 16 Dec 2019 17:03:37 +0000 Message-ID: <20191216170302.29543-9-Jerome.Pouiller@silabs.com> References: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 578197b9-dd56-4469-a355-08d78249e8a0 x-ms-traffictypediagnostic: MN2PR11MB3838: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(39860400002)(396003)(366004)(189003)(199004)(85202003)(8936002)(4744005)(81166006)(8676002)(54906003)(110136005)(316002)(85182001)(6506007)(186003)(2906002)(5660300002)(6512007)(26005)(107886003)(81156014)(36756003)(4326008)(6666004)(2616005)(76116006)(91956017)(64756008)(66556008)(66476007)(66946007)(71200400001)(86362001)(66446008)(6486002)(478600001)(1076003)(66574012);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB3838;H:MN2PR11MB4063.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uaskQuARV4OLxeMhtZbc7oh0QoZx68CbcrXqQPQHBDIPWDBQf8fwx3KOy9Qs5jXYbyI0RyjqF/EMTdiJRl3h36IfNdM+Ph7IzQ5vOwDK1QpVgfWpA72UhGAP9dPrl6BCvm3QgWupIOxZu2xvtMreabsdDPOMZDHvUDZgKkw7V0jk49uYYaqF0h4C3lQHEQ5A15Q1i9Nv66xeBQSzjbKOqoKKd6fVl/9IT3OaadrVNjslrawifbn/yL/jaHtsgNDSA6VayqjjgCTErUr8VWugNcNDJ6KBvpYWuQThXs0unhD/UI/dvybvxB8rOTBRfU3I1nx2ZyRlEhdWRvK9lP505sViTKfSQpZGJSlgetagRdg1ghatM5sESId1BTKgPJBneNGQJ+tiuFuGLAitIo8KPPvl1bwAIa4DMQIea8sU4FvpFeewRYVY3q4bsofHsgyP Content-ID: MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 578197b9-dd56-4469-a355-08d78249e8a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:03:37.3219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zo6S75+WcTuXRuqcyqz+4UqnAB1xh/PKrXFjHnZ/Z3Ds9nv4MLmyFgnvofcDhwCrep5g0A4AMB+Iiv3c+y5lQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3838 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Current code has a special case to handle association with WEP. Before to rework the tx data handling, let's try to detect any possible misuse of this code. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index c7ee90888f69..680fed31cefb 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -422,6 +422,7 @@ static bool hif_handle_tx_data(struct wfx_vif *wvif, struct sk_buff *skb, break; case do_wep: wfx_tx_lock(wvif->wdev); + WARN_ON(wvif->wep_pending_skb); wvif->wep_default_key_id = tx_priv->hw_key->keyidx; wvif->wep_pending_skb = skb; if (!schedule_work(&wvif->wep_key_work))