From patchwork Tue Dec 17 16:14:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 11298195 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 27E4214B7 for ; Tue, 17 Dec 2019 16:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0262924686 for ; Tue, 17 Dec 2019 16:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="h6JFMIws" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729483AbfLQQVA (ORCPT ); Tue, 17 Dec 2019 11:21:00 -0500 Received: from mail-eopbgr770059.outbound.protection.outlook.com ([40.107.77.59]:32421 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728387AbfLQQOj (ORCPT ); Tue, 17 Dec 2019 11:14:39 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R0xtDj1/ouMCxEWPsZLiGKaitYjL0uGVfGilhnP9yq1XBVE3oX9iZgsK41i4gLwYsodu8HIxtjpKUJishQvZhbkP0Zb9VuWsGInsswdL3pjgO4mQx5/yWTov/ZWCrenZVZUPB0bpArXbf8zV7EP2MGi0NQqSe8w9W2PR5442hbK4CEN/hOBY7OQv8y8B5Pu9UoYDzcO0bQw2RvW2CruqpqDvKRldDOYVWVrRucLVGcvLjGfP8HZJ4mG9xU1vDSlEPYMWrw9jHRL5sE3ochzTZqMXS0XHhAvlARDhgAHK5yAljvZuvTBDKyoZjiP8ZAvx7OFJ55fo/sMMvVGr+zrpXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UXO891/8R6v+gO7K16xmZhP1Ik0gLvhGwJ1VwG/esPs=; b=IYCi8a5oRog1hb4/0Qxorz2OQ+0xJhDjYHV182bn+juVPyqJyy6a3IzbC24T6/tMbprUURMUKxIoXwxUvBS5Z0Iostm4nOwKmI6ZLZKDyHcSoxG8xRgZYd3cOKcbCGB9n8nDurVAVIsJCHYZm3Dqe+L2rYTeHQ0+puxtEVXKm3TJ5YJVj2Prk0nv78lxEgV2hfcQ5yWfeALS6Gw6QXkWlDoeUnMvRWJM2x7JIclMOeCVe26VJdUdr0/adWOz2uQNa5cyf4q6IK7LOoPcuRCvZm83WbSf15T6NXmTJhkuxMqRXiBpV9SiNLMO1Se/mvr1NscWRmw1tntf9PcBOi5dOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UXO891/8R6v+gO7K16xmZhP1Ik0gLvhGwJ1VwG/esPs=; b=h6JFMIwsMOSC5w/m+nGn6o7HGVy1aBSIbWJMqI+KkgMepSSCLvdLFF5Ox2w2bS0r9ch1JQ7y+LUdyYpdP01rOYnRGZnkW9rLPTuWwo6jhcQgVhrX6pVxF2TMG1nUDXuNtgryYGXZWH2rlv1cr6T+LOIuSo2TD707I6nQSSxgpvU= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3678.namprd11.prod.outlook.com (20.178.254.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.16; Tue, 17 Dec 2019 16:14:37 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Tue, 17 Dec 2019 16:14:37 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 08/55] staging: wfx: detect race condition in WEP authentication Thread-Topic: [PATCH v2 08/55] staging: wfx: detect race condition in WEP authentication Thread-Index: AQHVtPUUqkxVBx5Uz0+0nJd0TGy/gg== Date: Tue, 17 Dec 2019 16:14:37 +0000 Message-ID: <20191217161318.31402-9-Jerome.Pouiller@silabs.com> References: <20191217161318.31402-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191217161318.31402-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PR0P264CA0174.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.24.0 x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be061756-d915-4535-bda4-08d7830c3662 x-ms-traffictypediagnostic: MN2PR11MB3678: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-forefront-prvs: 02543CD7CD x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(346002)(396003)(39840400004)(366004)(136003)(199004)(189003)(6512007)(66574012)(1076003)(4744005)(478600001)(86362001)(8936002)(110136005)(316002)(2616005)(26005)(6506007)(5660300002)(36756003)(6486002)(66946007)(66476007)(66556008)(64756008)(66446008)(71200400001)(52116002)(85182001)(81166006)(81156014)(8676002)(54906003)(107886003)(2906002)(4326008)(186003)(85202003);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB3678;H:MN2PR11MB4063.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5J99McFCkM/3lJGPAE31UgSTwvUXZZHQ4JJ6osOtGPZkHR+ufJJIAKvW6NVcZKkKpv+V0RkFCdehFPdTiQc9f283Q+EJq38c6SYM25gzXNCkfHMnKzKfxd/oZk9BpmkRK1jlXWzd8ZYwIaK/Bgrg4f9YRkWLKWkuAA/RFcBhIOw7hr+AhvbL2dKVmkTp841yofM8yKR2MVBU4CwyXeyKRGag0AB0L0u51yOet/cUO9K6bS4is9qY0bpSCs6E6zddl+u+MvCGQVP0adHMBCDzCTUrJ9LCeRLR8Oz+UK8umYnc2XsYYHjxbBCK/Ky3Plx+CN8GGFUuCa902q3WW/b+g+22SnSKFxS1fH/qY9CtMrMVAFmbfCOW2gVL4zb3SUfhKqwhInVNWFQpsOn6nowGdDyQRFythALo62rgQndU79IVq8NYQ2Ooe149jpArtS4Q Content-ID: <693C21275C1F0D4C888A47C0E60BF702@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: be061756-d915-4535-bda4-08d7830c3662 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2019 16:14:37.4150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K/bSdzY8krrCHYrzgW1nJKRDiypUZPEs9DSNjvie5muyT9+4ZyD164t4+p7B+kgv9x5vIWKY5umKKgcAUcXkyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3678 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Current code has a special case to handle association with WEP. Before to rework the tx data handling, let's try to detect any possible misuse of this code. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index c7ee90888f69..680fed31cefb 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -422,6 +422,7 @@ static bool hif_handle_tx_data(struct wfx_vif *wvif, struct sk_buff *skb, break; case do_wep: wfx_tx_lock(wvif->wdev); + WARN_ON(wvif->wep_pending_skb); wvif->wep_default_key_id = tx_priv->hw_key->keyidx; wvif->wep_pending_skb = skb; if (!schedule_work(&wvif->wep_key_work))