| Message ID | 20191217164329.4151-1-john@phrozen.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] dt: bindings: net: ath11k: add qcom,board_id definition | expand |
John Crispin <john@phrozen.org> writes: > We need to be able to define what id the board has allowing us to load the > correct definition data. This patch adds the description of the required > property. > > Signed-off-by: John Crispin <john@phrozen.org> > --- > .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > index a1717db36dba..c68daf6ad424 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > @@ -142,6 +142,11 @@ properties: > * reg > * reg-names > > + qcom,board_id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + The board id defining what board definition should be loaded I think this needs more discussion. This is very tricky to get right, as it needs to be extensible and what not. With ath10k we have learned that a simple integer is not enough.
On 19/12/2019 14:49, Kalle Valo wrote: > John Crispin <john@phrozen.org> writes: > >> We need to be able to define what id the board has allowing us to load the >> correct definition data. This patch adds the description of the required >> property. >> >> Signed-off-by: John Crispin <john@phrozen.org> >> --- >> .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> index a1717db36dba..c68daf6ad424 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml >> @@ -142,6 +142,11 @@ properties: >> * reg >> * reg-names >> >> + qcom,board_id: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The board id defining what board definition should be loaded > > I think this needs more discussion. This is very tricky to get right, as > it needs to be extensible and what not. With ath10k we have learned that > a simple integer is not enough. > I was expecting this, there seems to be an option to add ranges and/or enums. I did however fail to find any docs on the schemeas. John
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml index a1717db36dba..c68daf6ad424 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml @@ -142,6 +142,11 @@ properties: * reg * reg-names + qcom,board_id: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + The board id defining what board definition should be loaded + required: - compatible - reg
We need to be able to define what id the board has allowing us to load the correct definition data. This patch adds the description of the required property. Signed-off-by: John Crispin <john@phrozen.org> --- .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 5 +++++ 1 file changed, 5 insertions(+)