diff mbox series

ath11k: set TxBf parameters after vdev start

Message ID 20191217164917.5040-1-john@phrozen.org (mailing list archive)
State Accepted
Commit 5815719dd2714a369448159a562f6fdf75ffe87b
Delegated to: Kalle Valo
Headers show
Series ath11k: set TxBf parameters after vdev start | expand

Commit Message

John Crispin Dec. 17, 2019, 4:49 p.m. UTC 
From: Bhagavathi Perumal S <bperumal@codeaurora.org>

The channel info parameters are required by the firmware to process TxBf
parameters. Currently TxBf is passed prior to the channel info. This patch
moves TxBf setup after the channel setup.

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/mac.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Comments

Kalle Valo Jan. 26, 2020, 10:40 a.m. UTC | #1 
John Crispin <john@phrozen.org> wrote:

> The channel info parameters are required by the firmware to process TxBf
> parameters. Currently TxBf is passed prior to the channel info. This patch
> moves TxBf setup after the channel setup.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

5815719dd271 ath11k: set TxBf parameters after vdev start
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 9d0fed4034dd..a8ccb00d6072 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4216,12 +4216,6 @@  static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw,
 			    arvif->vdev_id, ret);
 	}
 
-	ret = ath11k_mac_set_txbf_conf(arvif);
-	if (ret) {
-		ath11k_warn(ar->ab, "failed to set txbf conf for vdev %d: %d\n",
-			    arvif->vdev_id, ret);
-	}
-
 	ath11k_dp_vdev_tx_attach(ar, arvif);
 
 	mutex_unlock(&ar->conf_mutex);
@@ -4573,6 +4567,11 @@  ath11k_mac_vdev_start_restart(struct ath11k_vif *arvif,
 			   arg.channel.freq, arg.vdev_id);
 	}
 
+	ret = ath11k_mac_set_txbf_conf(arvif);
+	if (ret)
+		ath11k_warn(ab, "failed to set txbf conf for vdev %d: %d\n",
+			    arvif->vdev_id, ret);
+
 	return 0;
 }