From patchwork Mon Jan 6 07:54:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 11318771 X-Patchwork-Delegate: luca@coelho.fi Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D5E80930 for ; Mon, 6 Jan 2020 08:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD5DA218AC for ; Mon, 6 Jan 2020 08:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578297842; bh=fGFBCPEl4r2sVFUgnN8WKF1RZ2HPIBBxFfZ7RS7c8RE=; h=From:To:Cc:Subject:Date:List-ID:From; b=WDpl4QTnsF1c8+KUiOxV9wE/6pvOJdCDWh5OZmHdoJGOl3B4UpqnBFyl+DvFF5bnr BU+CJRjWjXnZaKNmrKbq24KLWFLB/M154PYAEAFhgd0u2J1JDSbJc6IuN8F6DTkLo5 MqBiVeVbo7MZBSj9vfqbZvE7H2czFHiZvJHtJO4s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725908AbgAFIEB (ORCPT ); Mon, 6 Jan 2020 03:04:01 -0500 Received: from condef-09.nifty.com ([202.248.20.74]:20333 "EHLO condef-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgAFIEB (ORCPT ); Mon, 6 Jan 2020 03:04:01 -0500 X-Greylist: delayed 315 seconds by postgrey-1.27 at vger.kernel.org; Mon, 06 Jan 2020 03:04:00 EST Received: from conuserg-09.nifty.com ([10.126.8.72])by condef-09.nifty.com with ESMTP id 0067tUEZ001868 for ; Mon, 6 Jan 2020 16:55:32 +0900 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id 0067t0HK015985; Mon, 6 Jan 2020 16:55:00 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 0067t0HK015985 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1578297301; bh=efnKuYuz9lMVFzD60VImov9gE/cfNQG04Z6RLrlvcBI=; h=From:To:Cc:Subject:Date:From; b=OqTiVlEP/fkyxM1gu4IB+r9/4yKPkoItNtAoplP08Y/dGD1/Vd59g5avkZJTuN2ma aGlLfxaJTNJi/rrMea7KDUnZXOMRoLw1q9MeHqZzUyl4uc5aenKPuFjTYZUWwcDDRF AbtwzxCFBzis7hWTClf2+TMMcPxXGHiTv6Eddu5+cfzE58VvfVu8pXEn55C0BgEw1K Y+M2B0CBQuRm9C1KmSnZGn1Uhw3eWmk9uqBNxD24kAb0+R5+J6ysruDcWHJB0Ektgk j/KBJe9p6ENLN+kTNhUNJ09ZILGh48m1UEM4gp+YrrZQnljaJsjfWHXgOY8LDFcS7O mWCokwk9nTLSg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , linux-wireless@vger.kernel.org Cc: Masahiro Yamada , "David S. Miller" , Kalle Valo , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] iwlwifi: remove object duplication in Makefile Date: Mon, 6 Jan 2020 16:54:38 +0900 Message-Id: <20200106075439.20926-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The objects in $(iwlwifi-objs) $(iwlwifi-y) $(iwlwifi-m) are linked to iwlwifi.ko . This line adds $(iwlwifi-m) to iwlwifi-objs, so the objects from $(iwlwifi-m) are listed twice as the dependency of the module. It works because Kbuild trims the duplicated objects from linking, but there is no good reason to have this line. Signed-off-by: Masahiro Yamada --- drivers/net/wireless/intel/iwlwifi/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/Makefile b/drivers/net/wireless/intel/iwlwifi/Makefile index 0aae3fa4128c..a018d27a5410 100644 --- a/drivers/net/wireless/intel/iwlwifi/Makefile +++ b/drivers/net/wireless/intel/iwlwifi/Makefile @@ -19,8 +19,6 @@ iwlwifi-$(CONFIG_IWLMVM) += fw/paging.o fw/smem.o fw/init.o iwlwifi-$(CONFIG_ACPI) += fw/acpi.o iwlwifi-$(CONFIG_IWLWIFI_DEBUGFS) += fw/debugfs.o -iwlwifi-objs += $(iwlwifi-m) - iwlwifi-$(CONFIG_IWLWIFI_DEVICE_TRACING) += iwl-devtrace.o ccflags-y += -I$(src)