diff mbox series

ath5k: Add proper dependency for ATH5K_AHB

Message ID 20200224182447.4054-1-krzk@kernel.org (mailing list archive)
State Accepted
Commit c98cdaef931cb5553e42e928bd3f695d7a9cd9ee
Delegated to: Kalle Valo
Headers show
Series ath5k: Add proper dependency for ATH5K_AHB | expand

Commit Message

Krzysztof Kozlowski Feb. 24, 2020, 6:24 p.m. UTC
The CONFIG_ATH5K_AHB could be enabled on ATH25 system without enabling
ATH5K driver itself.  This does not make sense because CONFIG_ATH5K_AHB
controls object build within drivers/net/wireless/ath/ath5k/ so enabling
it without CONFIG_ATH5K brings nothing.

Add proper dependency to CONFIG_ATH5K_AHB.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/net/wireless/ath/ath5k/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo March 11, 2020, 4:52 p.m. UTC | #1
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> The CONFIG_ATH5K_AHB could be enabled on ATH25 system without enabling
> ATH5K driver itself.  This does not make sense because CONFIG_ATH5K_AHB
> controls object build within drivers/net/wireless/ath/ath5k/ so enabling
> it without CONFIG_ATH5K brings nothing.
> 
> Add proper dependency to CONFIG_ATH5K_AHB.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

c98cdaef931c ath5k: Add proper dependency for ATH5K_AHB
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath5k/Kconfig b/drivers/net/wireless/ath/ath5k/Kconfig
index 802f8f87773a..96010d4b00e7 100644
--- a/drivers/net/wireless/ath/ath5k/Kconfig
+++ b/drivers/net/wireless/ath/ath5k/Kconfig
@@ -54,7 +54,7 @@  config ATH5K_TRACER
 
 config ATH5K_AHB
 	bool "Atheros 5xxx AHB bus support"
-	depends on ATH25
+	depends on ATH25 && ATH5K
 	---help---
 	  This adds support for WiSoC type chipsets of the 5xxx Atheros
 	  family.