From patchwork Fri Aug 14 11:39:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11714395 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E533C1392 for ; Fri, 14 Aug 2020 11:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C888020866 for ; Fri, 14 Aug 2020 11:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RgQFNgl6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbgHNLm3 (ORCPT ); Fri, 14 Aug 2020 07:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728196AbgHNLkS (ORCPT ); Fri, 14 Aug 2020 07:40:18 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A937DC061348 for ; Fri, 14 Aug 2020 04:40:07 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id 9so7211446wmj.5 for ; Fri, 14 Aug 2020 04:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IFZOPtR6KI+rxA/lqxwIdqFyIwqMfS+8QowGRbn6S6c=; b=RgQFNgl65ZIR7EMkc8YqH6kzCDZzK/89NbSMs4w9VAwULPTsl0jNEfmDyXCvm0w3HF j5GajrrvhVxPKS/5R5bksj7YIWj5tsqvD2VViue+aMDKzPBO/FPUPxX6FHjEG/oMh4bq Ei4uXWbe4G2s+N6spzm1Yj4tWvfopFn2D879+kWi5cR4sP+OfELE2d2WxHIuMeHKWvMG WG5joLqe3oiEUTFgECwQznnGP46n2Po+9cDyOXClExY1/Qp5tZqQwn4+oXUXMprnVHDR 4mqoISP/KmmsqEYeuQGoxt72slmfKg0Njo46PAfR1+A0c1uOd3pnxnbMNZVp+NGv60LJ 8vhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IFZOPtR6KI+rxA/lqxwIdqFyIwqMfS+8QowGRbn6S6c=; b=HWvbuXUmDPcQX6mihhyf/AllCfOl+/RMOVFZKY/NE7wRMoJI/omyIU7+xIvVcs0HsF DVHcgnaSD+LhwhskIKsymmr6Qrl+Bj5WiF+yL/r/LKMRdBuTbun/cHrdUw9k16Vr923/ 8nMq0TXs2TSdw2MgySJldiaXkdDIcdysLKQEI6KBoI+3DKXCRx/uZcdrZjZUw8/UygZ2 3NHGtCEj9quVDMdVUhBsmMLuqvIhyB0VFPHgkp2vrgLFIKtH7wShgEHOjwWGrfQoTIpt KuDP+OMM7pbeYYzhTg2VG+SzrqNLDivVnn0QzDHrpCNBeFoowcZUleb8xzhLcpQNiHEY Trtw== X-Gm-Message-State: AOAM5304khtFODgjHJ9p9VbQbigU3jY3SXzCWXbfbRpQ3N9bhL5/UlXr RhKF/qdp50Ae5hKcnAYwXwFVyg== X-Google-Smtp-Source: ABdhPJyOkQHG7sfqRyJMAFAZsxAi8frxHRFAAgp/0CDRrGUgb2MXZIXsvYpokPZrFhEajNXubg+4AQ== X-Received: by 2002:a1c:18b:: with SMTP id 133mr2205145wmb.178.1597405206403; Fri, 14 Aug 2020 04:40:06 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id 32sm16409129wrh.18.2020.08.14.04.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2020 04:40:05 -0700 (PDT) From: Lee Jones To: davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, Lee Jones , Stanislav Yakovlev , Kalle Valo , Gerald Combs , Linux Wireless , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 16/30] net: wireless: intel: ipw2200: Remove set but unused variables 'rc' and 'w' Date: Fri, 14 Aug 2020 12:39:19 +0100 Message-Id: <20200814113933.1903438-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200814113933.1903438-1-lee.jones@linaro.org> References: <20200814113933.1903438-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function ‘ipw_irq_tasklet’: drivers/net/wireless/intel/ipw2x00/ipw2200.c:1953:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/intel/ipw2x00/ipw2200.c: In function ‘ipw_rx’: drivers/net/wireless/intel/ipw2x00/ipw2200.c:8251:9: warning: variable ‘w’ set but not used [-Wunused-but-set-variable] Cc: Stanislav Yakovlev Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Gerald Combs Cc: Linux Wireless Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 129ef2f6248ae..5345f90837f5f 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -1950,7 +1950,6 @@ static void ipw_irq_tasklet(unsigned long data) struct ipw_priv *priv = (struct ipw_priv *)data; u32 inta, inta_mask, handled = 0; unsigned long flags; - int rc = 0; spin_lock_irqsave(&priv->irq_lock, flags); @@ -1980,7 +1979,7 @@ static void ipw_irq_tasklet(unsigned long data) if (inta & IPW_INTA_BIT_TX_CMD_QUEUE) { IPW_DEBUG_HC("Command completed.\n"); - rc = ipw_queue_tx_reclaim(priv, &priv->txq_cmd, -1); + ipw_queue_tx_reclaim(priv, &priv->txq_cmd, -1); priv->status &= ~STATUS_HCMD_ACTIVE; wake_up_interruptible(&priv->wait_command_queue); handled |= IPW_INTA_BIT_TX_CMD_QUEUE; @@ -1988,25 +1987,25 @@ static void ipw_irq_tasklet(unsigned long data) if (inta & IPW_INTA_BIT_TX_QUEUE_1) { IPW_DEBUG_TX("TX_QUEUE_1\n"); - rc = ipw_queue_tx_reclaim(priv, &priv->txq[0], 0); + ipw_queue_tx_reclaim(priv, &priv->txq[0], 0); handled |= IPW_INTA_BIT_TX_QUEUE_1; } if (inta & IPW_INTA_BIT_TX_QUEUE_2) { IPW_DEBUG_TX("TX_QUEUE_2\n"); - rc = ipw_queue_tx_reclaim(priv, &priv->txq[1], 1); + ipw_queue_tx_reclaim(priv, &priv->txq[1], 1); handled |= IPW_INTA_BIT_TX_QUEUE_2; } if (inta & IPW_INTA_BIT_TX_QUEUE_3) { IPW_DEBUG_TX("TX_QUEUE_3\n"); - rc = ipw_queue_tx_reclaim(priv, &priv->txq[2], 2); + ipw_queue_tx_reclaim(priv, &priv->txq[2], 2); handled |= IPW_INTA_BIT_TX_QUEUE_3; } if (inta & IPW_INTA_BIT_TX_QUEUE_4) { IPW_DEBUG_TX("TX_QUEUE_4\n"); - rc = ipw_queue_tx_reclaim(priv, &priv->txq[3], 3); + ipw_queue_tx_reclaim(priv, &priv->txq[3], 3); handled |= IPW_INTA_BIT_TX_QUEUE_4; } @@ -8248,12 +8247,12 @@ static void ipw_rx(struct ipw_priv *priv) struct ipw_rx_mem_buffer *rxb; struct ipw_rx_packet *pkt; struct libipw_hdr_4addr *header; - u32 r, w, i; + u32 r, i; u8 network_packet; u8 fill_rx = 0; r = ipw_read32(priv, IPW_RX_READ_INDEX); - w = ipw_read32(priv, IPW_RX_WRITE_INDEX); + ipw_read32(priv, IPW_RX_WRITE_INDEX); i = priv->rxq->read; if (ipw_rx_queue_space (priv->rxq) > (RX_QUEUE_SIZE / 2))