| Message ID | 20200901035603.25180-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: Mark two variables as __maybe_unused | expand |
YueHaibing <yuehaibing@huawei.com> writes: > Fix -Wunused-variable warnings: > > drivers/net/wireless/ath/ath11k/debug.c:36:20: warning: ‘htt_bp_lmac_ring’ defined but not used [-Wunused-variable] > drivers/net/wireless/ath/ath11k/debug.c:15:20: warning: ‘htt_bp_umac_ring’ defined but not used [-Wunused-variable] > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> I don't like __maybe_unused so I decided to fix this with some refactoring: [1/4] ath11k: refactor debugfs code into debugfs.c https://patchwork.kernel.org/patch/11781017/
diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c index 0a3cfa716390..0b7842e8cc58 100644 --- a/drivers/net/wireless/ath/ath11k/debug.c +++ b/drivers/net/wireless/ath/ath11k/debug.c @@ -12,7 +12,7 @@ #include "debug_htt_stats.h" #include "peer.h" -static const char *htt_bp_umac_ring[HTT_SW_UMAC_RING_IDX_MAX] = { +static const __maybe_unused char *htt_bp_umac_ring[HTT_SW_UMAC_RING_IDX_MAX] = { "REO2SW1_RING", "REO2SW2_RING", "REO2SW3_RING", @@ -33,7 +33,7 @@ static const char *htt_bp_umac_ring[HTT_SW_UMAC_RING_IDX_MAX] = { "REO_STATUS_RING", }; -static const char *htt_bp_lmac_ring[HTT_SW_LMAC_RING_IDX_MAX] = { +static const __maybe_unused char *htt_bp_lmac_ring[HTT_SW_LMAC_RING_IDX_MAX] = { "FW2RXDMA_BUF_RING", "FW2RXDMA_STATUS_RING", "FW2RXDMA_LINK_RING",
Fix -Wunused-variable warnings: drivers/net/wireless/ath/ath11k/debug.c:36:20: warning: ‘htt_bp_lmac_ring’ defined but not used [-Wunused-variable] drivers/net/wireless/ath/ath11k/debug.c:15:20: warning: ‘htt_bp_umac_ring’ defined but not used [-Wunused-variable] Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireless/ath/ath11k/debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)