| Message ID | 20201222135113.20680-1-zhengyongjun3@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 73c655410181b7fc9a5ff321a5021a684ada99e7 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [wireless,v3,-next] brcmfmac: Delete useless kfree code | expand |
Zheng Yongjun <zhengyongjun3@huawei.com> wrote: > A null pointer will be passed to a kfree() call after a kzalloc() call failed. > This code is useless. Thus delete the extra function call. > > A goto statement is also no longer needed. Thus adjust an if branch. > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> Patch applied to wireless-drivers-next.git, thanks. 73c655410181 brcmfmac: Delete useless kfree code
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c index d821a4758f8c..d40104b8df55 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c @@ -319,8 +319,10 @@ static void brcmf_fw_strip_multi_v2(struct nvram_parser *nvp, u16 domain_nr, u8 *nvram; nvram = kzalloc(nvp->nvram_len + 1 + 3 + sizeof(u32), GFP_KERNEL); - if (!nvram) - goto fail; + if (!nvram) { + nvp->nvram_len = 0; + return; + } /* Copy all valid entries, release old nvram and assign new one. * Valid entries are of type pcie/X/Y/ where X = domain_nr and @@ -350,10 +352,6 @@ static void brcmf_fw_strip_multi_v2(struct nvram_parser *nvp, u16 domain_nr, kfree(nvp->nvram); nvp->nvram = nvram; nvp->nvram_len = j; - return; -fail: - kfree(nvram); - nvp->nvram_len = 0; } static void brcmf_fw_add_defaults(struct nvram_parser *nvp)
A null pointer will be passed to a kfree() call after a kzalloc() call failed. This code is useless. Thus delete the extra function call. A goto statement is also no longer needed. Thus adjust an if branch. Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- .../wireless/broadcom/brcm80211/brcmfmac/firmware.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)