diff mbox series

[net-next] iwlwifi: fix old-style-declaration warning

Message ID 20210322215124.1078478-1-arnd@kernel.org (mailing list archive)
State Superseded
Delegated to: Luca Coelho
Headers show
Series [net-next] iwlwifi: fix old-style-declaration warning | expand

Commit Message

Arnd Bergmann March 22, 2021, 9:51 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The correct order is 'static const', not 'const static', as seen from
make W=1:

drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]

Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Coelho March 23, 2021, 8:04 a.m. UTC | #1 
On Mon, 2021-03-22 at 22:51 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The correct order is 'static const', not 'const static', as seen from
> make W=1:
> 
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> 
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks, Arnd! But I just applied the patch Wei Yongjun submitted, so
we'll go with that one.

--
Cheers,
Luca.
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
index 873919048143..4d5a99cbcc9d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
@@ -11,7 +11,7 @@ 
  * DDR needs frequency in units of 16.666MHz, so provide FW with the
  * frequency values in the adjusted format.
  */
-const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
+static const struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
 	/* LPDDR4 */
 
 	/* frequency 3733MHz */