From patchwork Mon Sep 13 13:01:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12489005 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A0BC433F5 for ; Mon, 13 Sep 2021 13:04:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 710D060FA0 for ; Mon, 13 Sep 2021 13:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239048AbhIMNFV (ORCPT ); Mon, 13 Sep 2021 09:05:21 -0400 Received: from mail-dm6nam10on2042.outbound.protection.outlook.com ([40.107.93.42]:9633 "EHLO NAM10-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S240091AbhIMNEZ (ORCPT ); Mon, 13 Sep 2021 09:04:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtC7cSyeohkk9CAMmRxr55np665xY3G1fj/LRxEXiz125BPsw8IAox9XhnoQ+u2U89YEwcEcIxlIiu1lsQWPDMF9MEIpJVzKB1YIgHlmuo0OoJEUNKUS7oPYp0bn2VoPvurYH0mmmDU++nrPZq+Bo+LBaUcdXSLsoNILj0V9CIxJyijV66zGeUbjNZBOXOM0GuKYLrlQGtJ59wBL07PwmVgPUceUJepeE4XPuadqHB3HX5j9GyfE6b6/RaCgfKlhW6EucZjpUt35SBU+SdaqrxLkhLq98tdKxqUXzxwOA0j42wk5f2LvwQFjdCHgiEjLWUGnR19Ed97vjHw+OtUnUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bDkjZof4E6J1md+k828W5KwU9LtaDDRXypasdbyr1bo=; b=LeP/tj+sfDkPiHVqrJJH3mJn/XhuCh5TdIE0XgitP92YwxSjrdOUz+Qchj8WG//EgVihnB1ifwWVUA+VkvbhRFQnvWQpdC+bWfIMbES9EyE6822A6FoWAqlyF7gBe4PtaLyl3DbB91KYkxdOBj0Wh+fOOl11re90KCpkZxpRUzzPSyOzhugATUlSWqHZNQUOSpstU5U9KhhsdVMudfwU/6gPLSmtUpgA4rfCeL0L0Lu6uO/rByVwFeUm1N393tBcD8eL2ITVSGzzgS/nMA7ZEbkIq6jKhTaXWNGZ300pK5W83rae0G+ubE2ITC7rnTAWaDP/1VBEwbwgHtnizQQUuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDkjZof4E6J1md+k828W5KwU9LtaDDRXypasdbyr1bo=; b=f2o0DLIuFmcWUmA5lvZTCzX1BDOwj4TMx2l1AgL59KZbL3h6CnKx+uwb7U0uGm0IU2PNbF1QaRSm8BQbnGs8r539GsOOsiJRsDXxX1OP/mQt/NWHruMCW0NXsq/oMo/pn5oBKx14MOFXnGbhuoaa1/aMfRcKMNgAlRQExlSv2As= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SN6PR11MB3502.namprd11.prod.outlook.com (2603:10b6:805:da::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Mon, 13 Sep 2021 13:02:58 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 13:02:58 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v3 22/32] staging: wfx: remove useless debug statement Date: Mon, 13 Sep 2021 15:01:53 +0200 Message-Id: <20210913130203.1903622-23-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> References: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 13:02:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5a1f103-3945-41d7-d64b-08d976b6cf2d X-MS-TrafficTypeDiagnostic: SN6PR11MB3502: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rvkk0pPXt1qIjKel8MJjeRsoqzn9sm6/PcV78jrDrtdaNmCTPpeepG5dnA86fvZ0Qu54H5IW2tOAIdMuQCmLQhEv2aUMLOvQXQ3X4PjTdtAdWfnCaARbfuDamWSyFjpCiLskuG8jH8mcoQLIaSSvEada7S9Jpz9Z5+4Dq7wuDkptZiUezWV8Vdr7894bwFxvTcqj5Qis6hQrC9DZrfJreFS8xmP0NPXnBlx/Udu72KR/vL/gcNRrmo/ATuNCdhSEpRYlh57Fu6QfM8x8HbudkaBQJiTvb4H1XbUAVP6xUywqlPL2btOVR6fdCBnn5wU/HIOx+Q52tmcdssR2cgy2HeS+fSVigEzvYL3LvZshNXpct5JdZfsbQY2Kd8e6K6KPwgQIFvB+g+I4RvWvZfNhRSaL/OnSxukipqZ+rP7cPcsrfMNpri+JCa4HB5YriLktDesc/a4jvQLI+H5CuLoWh9iD8NNWf7MWTjmSH6XMaTIaF8Xabr9AoF/nOWil5iHDnkdGPVMfT3i8XfanWiMlEAbrTZDeuFFY206LDHFS7FhqEMX0nbQ1ZOVVnBqn2RTzzAqkq7lCzQwUBuSaIeqV+XOAagCBKm8yADhD6O6FQ673GQAprBIDPCTS36nS5pGKn1zJmM65166XYiEcxhuzCldI23Bujx2YYYYxxz4izZvGmOw1F6LqA79/uv9JslV8b7BhzLyt1zat+XRN0AHpfQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39850400004)(136003)(396003)(376002)(346002)(366004)(6666004)(316002)(66476007)(8676002)(186003)(4744005)(7696005)(52116002)(66946007)(26005)(4326008)(66556008)(2906002)(54906003)(107886003)(6486002)(2616005)(478600001)(1076003)(36756003)(5660300002)(66574015)(956004)(8936002)(86362001)(38100700002)(38350700002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?wZ2lQ97tt9XNyuytgI7AkheUMpfJ?= =?utf-8?q?SQNyJDdaXBrW/nEdVPxWDHTQwr3AXI4MqtGTnxvAZ3FosKfcBzuBUwqnB+ms+sQZ7?= =?utf-8?q?4rauu32iQivCA/3N56H43VCb1jzVVWXj9G6i1c6ugEJQpQ900UKVnNbzUOICCr0N3?= =?utf-8?q?kzlMzLPIrYoHgeNl3Sbitxa0BtkIaFWvs1Dka3CetoFxxOvAM6wFW4NnlrgjdDzHi?= =?utf-8?q?BL6h++G6riNFwC37GzHyTiTkInM4M/AfOMH6g5WiRcYyOD7GY+KtOd/uVLcW84BEC?= =?utf-8?q?92b7XXB7p7fgXjgcYWJ7bOf0GypHBahCWwQ+3kN6g3726/T3I/R67AKDjntcYhYBt?= =?utf-8?q?djq2T3Z176SrylGQ05Rkf9mVV30zuX9Vx91vULB41FHqztsJjG47hxJWXFlZuHh8y?= =?utf-8?q?tkHFtxMn7O4xY71TRblSLKstd5PxbEELz2Id/6tSWwscX0xi5YgPFqb0ZKOUQYoDW?= =?utf-8?q?0Rdf7MuqIepd+pYdsEw5mqRIc6956NOVeqwByzyCyYQVMjjoi98/SWmoNNy1AQqx/?= =?utf-8?q?oO2FUBMos4Moiinf6BeUNTnImaYTBP3985XyuP0q9UqD0HCqfhwileHuE8965ysM2?= =?utf-8?q?0tO3jT2HuOU5hcZ/V9YkvqZBjXHHFwxr/z/LEde13Fu5hd7MsGmjNzVIlzbjpKHYK?= =?utf-8?q?NZuRVVMKNn4W2JbrRbFfPY0BZcUvF5fPIDQtfpnz+xR6TAwW72UrIxAJy1r1BN7c2?= =?utf-8?q?ngAsNO88Ud8I6TcCsK8du0A6etQWKl5XbOrH8Xj9+MZpJjavIo9CWEb6jUrXnrUft?= =?utf-8?q?gdeNzk9RI2xWz43EpVutvHQeCeN/8lhiyMKeZeAHZXdW0bakiYuIm4B0GN9v1U+it?= =?utf-8?q?PWD1a6UdgiG2rt0+xq0tMNjwaOYVlLreuw+JhTsLF+80JoGX0ekdjwbBKuLeZiX2A?= =?utf-8?q?4j6naBcNTBLVQarkLZyiib9VtVH776+hLJgCwBWwI1TW0Ud1pmM5kbquSUoEjWu3O?= =?utf-8?q?QQNLzBKODMdx6VZP//qz4mD6H4zvd9iFo2FgqyBCK8ggg4Tw+EeST9azyqsus9MVT?= =?utf-8?q?AWX0oEA+/8j8IwFgG9Q7dXamC/4wbhU4q+PBFLsY+lrgHVMl41enpW49FpiMhyCst?= =?utf-8?q?wZx6evajK1lxp00VmDsdOcYzt07RtF5J5xIqS9Euc+6vVxmR+exPfa3I0n3BruiDB?= =?utf-8?q?Dc3xX/J5esU6UXqv6lkS1Xi0s3stqkY6n5l6ny3qn0e2vAG0bhBx6S5qmPzAIyQgU?= =?utf-8?q?nH17ZY0h2nZNIJ8FEJSr6TElSTGavTxhjLPI1DUmfSD9AEh5+uimgUR4VSs4yHmJB?= =?utf-8?q?vzBzQn8epavNAkG2?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5a1f103-3945-41d7-d64b-08d976b6cf2d X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 13:02:58.4297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s2eawy0tq3JHj2AtFtEsGzNJPAjI3ov/2t3wHjI5f/YXRadN5FYAp71qoxm9RztKi/KlnjNWNwU4YdpRaTZqdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3502 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller In the early age, it was unexpected to access a VIF that did not exist. With current code, this happens frequently. Having a trace associated on this event brings absolutely no informations. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/wfx.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wfx/wfx.h b/drivers/staging/wfx/wfx.h index 56f1e4bb0b57..a8efa25a38ac 100644 --- a/drivers/staging/wfx/wfx.h +++ b/drivers/staging/wfx/wfx.h @@ -99,11 +99,8 @@ static inline struct wfx_vif *wdev_to_wvif(struct wfx_dev *wdev, int vif_id) return NULL; } vif_id = array_index_nospec(vif_id, ARRAY_SIZE(wdev->vif)); - if (!wdev->vif[vif_id]) { - dev_dbg(wdev->dev, "requesting non-allocated vif: %d\n", - vif_id); + if (!wdev->vif[vif_id]) return NULL; - } return (struct wfx_vif *) wdev->vif[vif_id]->drv_priv; }