| Message ID | 20211025093037.3966022-2-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 43ea9bd84f27d06482cc823d9749cc9dd2993bc8 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wcn36xx: Revert firmware link monitoring | expand |
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > Firmware link offload monitoring can be made to work in 3/4 cases by > switching on firmware feature bit WLANACTIVE_OFFLOAD > > - Secure power-save on > - Secure power-save off > - Open power-save on > > However, with an open AP if we switch off power-saving - thus never > entering Beacon Mode Power Save - BMPS, firmware never forwards loss > of beacon upwards. > > We had hoped that WLANACTIVE_OFFLOAD and some fixes for sequence numbers > would unblock this but, it hasn't and further investigation is required. > > Its possible to have a complete set of Secure power-save on/off and Open > power-save on/off provided we use Linux' link monitoring mechanism. > > While we debug the Open AP failure we need to fix upstream. > > This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 43ea9bd84f27 Revert "wcn36xx: Enable firmware link monitoring"
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index dd8810fd76a3d..fd8b2753da7dd 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn) ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL); ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS); ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS); - ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR); wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) | BIT(NL80211_IFTYPE_AP) |
Firmware link offload monitoring can be made to work in 3/4 cases by switching on firmware feature bit WLANACTIVE_OFFLOAD - Secure power-save on - Secure power-save off - Open power-save on However, with an open AP if we switch off power-saving - thus never entering Beacon Mode Power Save - BMPS, firmware never forwards loss of beacon upwards. We had hoped that WLANACTIVE_OFFLOAD and some fixes for sequence numbers would unblock this but, it hasn't and further investigation is required. Its possible to have a complete set of Secure power-save on/off and Open power-save on/off provided we use Linux' link monitoring mechanism. While we debug the Open AP failure we need to fix upstream. This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 1 - 1 file changed, 1 deletion(-)