| Message ID | 20211206232709.3192856-3-davidm@egauge.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5ae660641db824ecc9c7a49546dff701c6dc7ca7 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] wilc1000: Fix copy-and-paste typo in wilc_set_mac_address | expand |
On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: > Add missing newline in pr_err() message. [] > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c [] > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) > struct wilc *wilc = user_data; > > if (wilc->close) { > - pr_err("Can't handle UH interrupt"); > + pr_err("Can't handle UH interrupt\n"); Ideally this would use wiphy_<level>: wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n");
On 12/6/21 6:33 PM, Joe Perches wrote: > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: >> Add missing newline in pr_err() message. > [] >> diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c > [] >> @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) >> struct wilc *wilc = user_data; >> >> if (wilc->close) { >> - pr_err("Can't handle UH interrupt"); >> + pr_err("Can't handle UH interrupt\n"); > Ideally this would use wiphy_<level>: > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); Sure, but that's orthogonal to this bug fix. I do have a "cleanups" branch with various cleanups of this sort. I'll look into fixing pr_*() calls in the cleanups branch (there are several of them, unsurprisingly). --david
On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote: > On 12/6/21 6:33 PM, Joe Perches wrote: > > > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: > > > Add missing newline in pr_err() message. > > [] > > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c > > [] > > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) > > > struct wilc *wilc = user_data; > > > > > > if (wilc->close) { > > > - pr_err("Can't handle UH interrupt"); > > > + pr_err("Can't handle UH interrupt\n"); > > Ideally this would use wiphy_<level>: > > > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); > > Sure, but that's orthogonal to this bug fix. Of course. > I do have a "cleanups" > branch with various cleanups of this sort. I'll look into fixing pr_*() > calls in the cleanups branch (there are several of them, unsurprisingly). netdev_<level> -> wiphy_<level> conversions too where feasible please.
On Tue, 2021-12-07 at 16:23 -0800, Joe Perches wrote: > On Tue, 2021-12-07 at 15:58 -0700, David Mosberger-Tang wrote: > > On 12/6/21 6:33 PM, Joe Perches wrote: > > > > > On Mon, 2021-12-06 at 23:27 +0000, David Mosberger-Tang wrote: > > > > Add missing newline in pr_err() message. > > > [] > > > > diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c > > > [] > > > > @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) > > > > struct wilc *wilc = user_data; > > > > > > > > if (wilc->close) { > > > > - pr_err("Can't handle UH interrupt"); > > > > + pr_err("Can't handle UH interrupt\n"); > > > Ideally this would use wiphy_<level>: > > > > > > wiphy_err(wilc->wiphy, "Can't handle UH interrupt\n"); > > > > Sure, but that's orthogonal to this bug fix. > > Of course. > > > I do have a "cleanups" > > branch with various cleanups of this sort. I'll look into fixing pr_*() > > calls in the cleanups branch (there are several of them, unsurprisingly). > > netdev_<level> -> wiphy_<level> conversions too where feasible please. OK, I made a note for that, too, thanks. --david
diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c index 690572e01a2a..633cb3a43f6a 100644 --- a/drivers/net/wireless/microchip/wilc1000/netdev.c +++ b/drivers/net/wireless/microchip/wilc1000/netdev.c @@ -27,7 +27,7 @@ static irqreturn_t isr_uh_routine(int irq, void *user_data) struct wilc *wilc = user_data; if (wilc->close) { - pr_err("Can't handle UH interrupt"); + pr_err("Can't handle UH interrupt\n"); return IRQ_HANDLED; } return IRQ_WAKE_THREAD;
Add missing newline in pr_err() message. Signed-off-by: David Mosberger-Tang <davidm@egauge.net> --- drivers/net/wireless/microchip/wilc1000/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)