| Message ID | 20211220180334.3990693-3-davidm@egauge.net (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wilc1000: Add reset/enable GPIO support to SPI driver | expand |
On Mon, 20 Dec 2021 18:03:38 +0000, David Mosberger-Tang wrote: > Add documentation for the ENABLE and RESET GPIOs that may be needed by > wilc1000-spi. > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> > --- > .../net/wireless/microchip,wilc1000.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On Tue, 2021-12-21 at 11:12 -0400, Rob Herring wrote: > On Mon, 20 Dec 2021 18:03:38 +0000, David Mosberger-Tang wrote: > > Add documentation for the ENABLE and RESET GPIOs that may be needed > > by > > wilc1000-spi. > > > > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> > > --- > > .../net/wireless/microchip,wilc1000.yaml | 19 > > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > Please add Acked-by/Reviewed-by tags when posting new versions. Ah, sorry about that. > However, > there's no need to repost patches *only* to add the tags. The > upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. Not on purpose. I just didn't know how this is handled. Thanks and best regards, --david
David Mosberger-Tang <davidm@egauge.net> writes: > On Tue, 2021-12-21 at 11:12 -0400, Rob Herring wrote: >> On Mon, 20 Dec 2021 18:03:38 +0000, David Mosberger-Tang wrote: >> > Add documentation for the ENABLE and RESET GPIOs that may be needed >> > by >> > wilc1000-spi. >> > >> > Signed-off-by: David Mosberger-Tang <davidm@egauge.net> >> > --- >> > .../net/wireless/microchip,wilc1000.yaml | 19 >> > +++++++++++++++++++ >> > 1 file changed, 19 insertions(+) >> > >> >> Please add Acked-by/Reviewed-by tags when posting new versions. > > Ah, sorry about that. > >> However, >> there's no need to repost patches *only* to add the tags. The >> upstream >> maintainer will do that for acks received on the version they apply. >> >> If a tag was not added on purpose, please state why and what changed. > > Not on purpose. I just didn't know how this is handled. No worries, we have a lot of special rules :) I'll add Rob's tag from v5 when I commit the patch. Actually, I'm lazy and patchwork can pick it up automatically: Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml index 6c35682377e6d..60de78f1bc7b9 100644 --- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml @@ -32,6 +32,21 @@ properties: clock-names: const: rtc + enable-gpios: + maxItems: 1 + description: Used by wilc1000-spi to determine the GPIO line + connected to the ENABLE line. If specified, reset-gpios + must be specified as well as otherwise the driver cannot + ensure the timing required between asserting ENABLE + and deasserting RESET. This should be declared as an + active-high signal. + + reset-gpios: + maxItems: 1 + description: Used by wilc1000-spi to determine the GPIO line + connected to the RESET line. This should be declared as an + active-low signal. + required: - compatible - interrupts @@ -40,6 +55,8 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> + spi { #address-cells = <1>; #size-cells = <0>; @@ -51,6 +68,8 @@ examples: interrupts = <27 0>; clocks = <&pck1>; clock-names = "rtc"; + enable-gpios = <&pioA 5 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pioA 6 GPIO_ACTIVE_LOW>; }; };
Add documentation for the ENABLE and RESET GPIOs that may be needed by wilc1000-spi. Signed-off-by: David Mosberger-Tang <davidm@egauge.net> --- .../net/wireless/microchip,wilc1000.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)