From patchwork Thu Jan 13 08:55:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12712452 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749CCC433FE for ; Thu, 13 Jan 2022 08:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233085AbiAMI4T (ORCPT ); Thu, 13 Jan 2022 03:56:19 -0500 Received: from mail-co1nam11on2086.outbound.protection.outlook.com ([40.107.220.86]:28322 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231932AbiAMI4N (ORCPT ); Thu, 13 Jan 2022 03:56:13 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kxj9mthRkgJi2evWfwuAd9+uKO4PmTKI6tGHtanohLqB2TR6RSAKmhZb5GmGJ/ts2/yjbYTIl2Ifv63N8MPIEf5Wc/btl6ShdLAAkd/gDW+jhPidirYBqqZEVHF+8ZOQYagW4of+gQbSImcgVMRAor8hIwM7/6t0Qngh0r3udYlINwtqjagAC6DifLu9M83+DOPCErTzD/7oaybkvR71QpDolBB7Xkxk/HPV8nCWCGV4v+Br+ajf3b7YmWLqZ3xGg1IymgUogbf+veglahdF0Igp4Ofq57nuQ+/I6+LO2/+9WgfWu8A/jUf/UWDEvySSfuJwXGqvxcG0szgutiQ5eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ROux8YOXP+rBzV4eXP78mZycZroqTVJCivRcn4Gly7g=; b=aFwYfe+6WrsF2KwZOkmjzdsEJLuM5YKAU1gSvZ4uYHYWblW9Z7x+BrT6U79zOEYefeXRzRO3mi8a03bQ95L18rLPs6ft9BJtx2XY8xzCKrnXI0DSYUx8e9ltDqSM4ZX+jpEsNPh0Lyzr/pNceBWNlw0aRgqIodpTxKgqr5K43vMKxnoI0jqw0y6mBC7KASxv5ydd7f0gyKxpRqrBEHh0ouDCNhzNbXMwar1sh2UQLVzBOHQWK1IFymtb/TryLWp2gMVxwSAjUYhC62FFPq9frwJ+5G9skex4v4RlQtegbGKldDKN4C+Plc3grf09H5WESbgW5ED9ro6rblX6Jc9fwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ROux8YOXP+rBzV4eXP78mZycZroqTVJCivRcn4Gly7g=; b=bvNx8Mdiyt1C4SvcO4S1B+k3OQlVMJT//rgnNKRY7ocFgdEvq+RA84DXcgw9FQWHrOUHVJrRn9FdgWUneeGCgZha//IfpQ0jfkyN7LwLiA7QvCR4M2LysyRRtfoIWT8AOKiTqkNgz/6ShsVe399qicxmH3hZnHBrj0FWvwST25A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BY5PR11MB4040.namprd11.prod.outlook.com (2603:10b6:a03:186::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Thu, 13 Jan 2022 08:55:57 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::d031:da9e:71a:73e4]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::d031:da9e:71a:73e4%5]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 08:55:57 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 10/31] stagigg: wfx: replace magic number by HIF_ID_IS_INDICATION Date: Thu, 13 Jan 2022 09:55:03 +0100 Message-Id: <20220113085524.1110708-11-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220113085524.1110708-1-Jerome.Pouiller@silabs.com> References: <20220113085524.1110708-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: SA0PR11CA0117.namprd11.prod.outlook.com (2603:10b6:806:d1::32) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62ff95cf-b803-42d7-ee31-08d9d67283b5 X-MS-TrafficTypeDiagnostic: BY5PR11MB4040:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:151; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9hvHaP5ZuyODDlEljtxJvYX4dtbSkKQ8p70TiAiROZx2LPsf2/nNgZOF/gmHbAJYxmQb7AUuttTsWjaO/b56E+tSIRMbukOfCuStpC4Z0sxaGYPK1ftCYPgJzaiPTRKy73+DlNvhadJfI31KpsZuIIe0v3hoZ4xhhCEtD29Aet8+pmnzrPjL7AHx/1pxIvC6z4fyq3zXzN99P5huMxJ8nOxCOz6BJQEvoUk9AnH5w2zQ/Qi5xEJUqp2wDrUfempU7DfLw85qDjtx5kY40P70pFeIdEAqzFkUjd6PKyeokR+87hY4Ahq8VgNJw4V91yC6hxTNqfEdyKDk57LFZDtp4yPc7pdVgc0+x5VGZawcTYZdDosZrCouBUu7/moRX4A7UZU+WcqgF1SqK7tDYzTWsIxYjCX04LCQK6/5EjllTxwPclx86odrFB5+wnPd7HfgJznz0Zm5jtqyr1zCACHJIH5tFxNBMW9Z8UFP/AwqIV4sQ+PExsJaxVM8Pf8kqMf3vSEQq9X3y18CIuFvAsoVhsFUx3YLzQShHx12xvEgq7kmzh1IAPhzQQUcPg4oCFymE1VGmtHIxvaLmZ9+yaq7BKC3KTbA7ngFn1Yi9UNHjXx75ssNAyxNe7uMehHVhBeac0nDeprMG87KKaVfKxZFnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(508600001)(186003)(38100700002)(4744005)(4326008)(8936002)(6512007)(6666004)(66946007)(83380400001)(1076003)(2616005)(54906003)(86362001)(66556008)(2906002)(66476007)(316002)(52116002)(36756003)(5660300002)(66574015)(8676002)(6486002)(107886003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6Mm47+beVSyUwHS+yYrgRX/2l4gy?= =?utf-8?q?flkMTgqa7PESSVdZqfwfBjHJb6MzkZTFMLmxOUStwn/6TEPL9dxqjZiHmcXAKFWeM?= =?utf-8?q?erWanWYtoJ7Mal2jYki38xn+OiUx/KKuOUCbIU8ScqPFT5Xzt2N5PP0lCBd9havDX?= =?utf-8?q?syQgQEpJcWing9I0nrfjf+oBLRp7+ZcGdkFzZaYu6UN65CzdZRhhZ9/s0e+eS53d/?= =?utf-8?q?tHch56CRh5gsPbuOkEBpEyFRofZiAbaXfs40zKUgFsMdj/p25D2shCFl5ZRNC9L1i?= =?utf-8?q?fRbMk80uvhZdrb0nfO2KGUMR90qIu0Oo70CunGA4r/UIXvZ6PAN8NxY7yMkT1P81G?= =?utf-8?q?vsQVNamgQzsTfIi22Fem+m044I86iNQW36WAnenPfVcO0N4JABFDwW005t4Xx3M0n?= =?utf-8?q?rofAJRXA8tcBViVKuUMWnMETBpmWxO042pcCy88voWfylo7TenhBF/L4g/EmRrxTc?= =?utf-8?q?fOytp7bKNH86xN0QzmDUa8EavkaSqJKBAqacV8HRO+EUS6XPjc270S/ZxYOKivusE?= =?utf-8?q?MMhEXSrIPe1mPtofiCynmjYjueqJ7E9PF+MUI1PbPc+NrlIJgRLRpqWAehQl8dkhq?= =?utf-8?q?PhhhyWdd7qxvFRFX1L3xikrozJHCEX7rdX0BS9rIq12eu3lDEm3HlI/taV+IpKqYx?= =?utf-8?q?FICqZ2sIOdQ/nraNXwZszX4iaode7uB0Ve7cwTxyWBHqcFq32ybNJzhQiVQ1fXk3A?= =?utf-8?q?gaSp0EBUYpBQQyw90P/EqZ9YzwJrKWtcTDfKITc+hY2DWECL9xP+8wvOcNJM1zOla?= =?utf-8?q?i89EMvGZtEBx9ysV5o0vpkpsL6VYPBjtjGgWJ3FgyOqP2OuhhkBwcGsG4PWjLDhYm?= =?utf-8?q?hB3rRc6f95cOs4Ns5myJnp6Dui2ctvBecpDD5xuHvSxO53GjgGh9+a8ORf5/Lw8qV?= =?utf-8?q?fRrJazQZkQswDPfzQykKvuAXwWlGYeahxMwptRN4O2VIoj6n6zbhXm0RCHaH7zD0S?= =?utf-8?q?DO6GZ8tx+kF8d45iRjQ8BRw0CaAkA60QLzKC+7HATmBnx0PSno7tpN9qmFPJhryH7?= =?utf-8?q?6u51y0ndegXazHotejTMFuK1YsrSgRcIiVn7KOX9TyYm9aBGdllK2gtHs2T8ChOeb?= =?utf-8?q?eBxu2/VyDX9bsevNdYeJJoJ5HIA8jeP0tUdUZmMlTgRBPsUETxE5zkse1oJC7yU75?= =?utf-8?q?AjXTstIEepLbv4zNcZhXmb3JW4SoIdCxAc0SNzdwr8z4QrcrGvghyGhWSJ3fkk/R/?= =?utf-8?q?N+BVIFiRqmBKiRCoF47C0pX0mxPK93e3/XvVgjjibL760Dzlt6oa+CDDtFP8su8j7?= =?utf-8?q?96z1ofoTfW0Ah2wiggzyk1wygcCeHeUhCgLrTpZG75VLlKEwm0YNI8syHvxPVvCQ4?= =?utf-8?q?+/mRAMvoV8ksURC8XhDpb12E5ucCrYLnXkWGyJpx93wNeiIcjM90ApTcUrWwTs3uo?= =?utf-8?q?eHJS8LZXMsbRjt1JNf49/F1qqYhx4A2W9j8ZR6zh8sntkljjqqtKdx5O5xDhVS/ia?= =?utf-8?q?6sT7ZgjPRLBo6/zD1hP7hJqnraKedLCpQSt5ccs2imTsQXPQ6x6y37s4lud8pqFTj?= =?utf-8?q?d++pwRLUZEbCp4DiJ0ehFV9/irL4Zxyh9O2tICtTDpwoE5l1WZOJ/K76shGUuiZ0k?= =?utf-8?q?e5soL8slckg62fqA9BcNUprVgzEv29X8AIxFS4dZLIQMYlfVj4mZRs=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62ff95cf-b803-42d7-ee31-08d9d67283b5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2022 08:55:57.6168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a2JCC1ynTGH8bqqi7CloWD8KkWSnUNiqtEqfgw2VO9+/DuZJCprsbfW45AMiriA5PCtfOQjYAiJ1xbQ/44ZL7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4040 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Magic values are not recommended. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 6963b54d5593..5e675d2c3e82 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -405,7 +405,7 @@ void wfx_handle_rx(struct wfx_dev *wdev, struct sk_buff *skb) goto free; } } - if (hif_id & 0x80) + if (hif_id & HIF_ID_IS_INDICATION) dev_err(wdev->dev, "unsupported HIF indication: ID %02x\n", hif_id); else