| Message ID | 20220125180735.1123792-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | ieee80211: cleanup double word in comment | expand |
On Tue, 2022-01-25 at 10:07 -0800, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Remove the second 'that'. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > include/linux/ieee80211.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h > index 559b6c6449384..5475383936f8b 100644 > --- a/include/linux/ieee80211.h > +++ b/include/linux/ieee80211.h > @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc) > static inline bool ieee80211_is_data_present(__le16 fc) > { > /* > - * mask with 0x40 and test that that bit is clear to only return true > + * mask with 0x40 and test that bit is clear to only return true > * for the data-containing substypes. > I don't think it's just a duplicate? ... and (test that) (that bit is clear to ...) no? johannes
On Tue, 2022-01-25 at 10:07 -0800, trix@redhat.com wrote: > Remove the second 'that'. [] > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h [] > @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc) > static inline bool ieee80211_is_data_present(__le16 fc) > { > /* > - * mask with 0x40 and test that that bit is clear to only return true > + * mask with 0x40 and test that bit is clear to only return true This is likely a false positive... "that that" is frequently correct usage. "that the" might be acceptable here instead. Not sure about the "only" use though. Maybe fix the substypes typo too. --- include/linux/ieee80211.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h index 559b6c6449384..0d9864adf9911 100644 --- a/include/linux/ieee80211.h +++ b/include/linux/ieee80211.h @@ -467,8 +467,8 @@ static inline bool ieee80211_is_data_qos(__le16 fc) static inline bool ieee80211_is_data_present(__le16 fc) { /* - * mask with 0x40 and test that that bit is clear to only return true - * for the data-containing substypes. + * mask with 0x40 and test that the bit is clear to return true + * only for the data-containing subtypes. */ return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | 0x40)) == cpu_to_le16(IEEE80211_FTYPE_DATA);
On 1/25/22 10:19 AM, Johannes Berg wrote: > On Tue, 2022-01-25 at 10:07 -0800, trix@redhat.com wrote: >> From: Tom Rix <trix@redhat.com> >> >> Remove the second 'that'. >> >> Signed-off-by: Tom Rix <trix@redhat.com> >> --- >> include/linux/ieee80211.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h >> index 559b6c6449384..5475383936f8b 100644 >> --- a/include/linux/ieee80211.h >> +++ b/include/linux/ieee80211.h >> @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc) >> static inline bool ieee80211_is_data_present(__le16 fc) >> { >> /* >> - * mask with 0x40 and test that that bit is clear to only return true >> + * mask with 0x40 and test that bit is clear to only return true >> * for the data-containing substypes. >> > I don't think it's just a duplicate? > > ... and (test that) (that bit is clear to ...) > > no? ok, reads ok. Sorry for the noise. T > > johannes >
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h index 559b6c6449384..5475383936f8b 100644 --- a/include/linux/ieee80211.h +++ b/include/linux/ieee80211.h @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc) static inline bool ieee80211_is_data_present(__le16 fc) { /* - * mask with 0x40 and test that that bit is clear to only return true + * mask with 0x40 and test that bit is clear to only return true * for the data-containing substypes. */ return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | 0x40)) ==