| Message ID | 20220331002105.1162099-1-quic_bqiang@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2dd398dee7aa5ec6b296d9915bbb1c1a76199b4a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath11k: Remove unnecessary delay in ath11k_core_suspend | expand |
Baochen Qiang <quic_bqiang@quicinc.com> wrote: > The intended delay in ath11k_core_suspend is introduced in commit > d1b0c33850d2 ("ath11k: implement suspend for QCA6390 PCI devices"), > now with ath11k_mac_wait_tx_complete added in commit ba9177fcef21 > ("ath11k: Add basic WoW functionalities"), that delay is not > necessary now, so remove it. > > This is found in code review. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-02431-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 2dd398dee7aa ath11k: Remove unnecessary delay in ath11k_core_suspend
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 7f4462cf5787..509bfffceba1 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -459,11 +459,6 @@ int ath11k_core_suspend(struct ath11k_base *ab) if (!ar || ar->state != ATH11K_STATE_OFF) return 0; - /* TODO: there can frames in queues so for now add delay as a hack. - * Need to implement to handle and remove this delay. - */ - msleep(500); - ret = ath11k_dp_rx_pktlog_stop(ab, true); if (ret) { ath11k_warn(ab, "failed to stop dp rx (and timer) pktlog during suspend: %d\n",
The intended delay in ath11k_core_suspend is introduced in commit d1b0c33850d2 ("ath11k: implement suspend for QCA6390 PCI devices"), now with ath11k_mac_wait_tx_complete added in commit ba9177fcef21 ("ath11k: Add basic WoW functionalities"), that delay is not necessary now, so remove it. This is found in code review. Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-02431-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> --- drivers/net/wireless/ath/ath11k/core.c | 5 ----- 1 file changed, 5 deletions(-) base-commit: 748b34786d1c96e758862d8e8577106ccde6515a