From patchwork Sat May 21 20:37:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12858031 X-Patchwork-Delegate: gregory.greenman@intel.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52581C433F5 for ; Sat, 21 May 2022 20:38:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345921AbiEUUiD (ORCPT ); Sat, 21 May 2022 16:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238295AbiEUUh7 (ORCPT ); Sat, 21 May 2022 16:37:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2928A3A5EF for ; Sat, 21 May 2022 13:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653165476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lV7BrdQ4ujV3JaRxGlibSyfD3tp6S+keiDHJLEnX4rI=; b=RAqbyOmS51ievNl7ApfytWFWmF9+VsQ7oPavDcLx4zGmdhM5YYr0qykstW7Iy31DzHxZck j7h6h4hstiuXSRTA89R5MvhtLxU+GlG4XafCnnLwJbbLQNCkiwodjwcnxzlKxDspUDjF8U c7cZjbVGyIIMozgc8xfIY653FBTa6Xk= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-pHYCEVbON-CVlKowNKhhCw-1; Sat, 21 May 2022 16:37:55 -0400 X-MC-Unique: pHYCEVbON-CVlKowNKhhCw-1 Received: by mail-oo1-f70.google.com with SMTP id c1-20020a4aa4c1000000b0035e95332a48so5417683oom.7 for ; Sat, 21 May 2022 13:37:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lV7BrdQ4ujV3JaRxGlibSyfD3tp6S+keiDHJLEnX4rI=; b=xH8wqnilhT3wKfCH3Uga2ZYSvioDAWo+vfjNPGXMM2Zo5wWvJaaQaYOV4AcFzeYiIX E6S1oATor1ajBx34w1BPqMgAyUqYvT3HyH7XBjbtFRZT0MWHo3zJ3I2dKB7a3lmZ0FgC XrjUqe7YxiftWYCCmsjSZDVGKb0QCjRL6wEUBQO+Q1D57+kkwMzCTM0IJDS2tl0URiZl 4UKv7y0pidkknAYbbWyU/OGXH8onmZl0g4JPdKPvB0tbWrzhKxqzkWUBHKFI6mz9S6I/ 7c76aLLYFNABG+zWcPL/W6k2LHnqkhQuWmgixCld/K0txINnUN083xyQfsea6waVVPuS IEUA== X-Gm-Message-State: AOAM532zFivW/Pz6PWo5Gcft827amkgMo0MH8JImR/CUlkbSrGRObRYf 07fG7OxyNI02ZY9GVtOyelfO0/m4hqanvkrXXe67k/fPIl7DitmHQZOyjrwf6PSiuJqWfsHt4dn t7jtoT7rNwZD+dclWLsU6emIZ0zg= X-Received: by 2002:a05:6808:1814:b0:32b:851:35d5 with SMTP id bh20-20020a056808181400b0032b085135d5mr4002292oib.206.1653165474493; Sat, 21 May 2022 13:37:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIxKBUfhEWEra9+wIF21FKv7KmWa9pxAfcrwEuD/KklNUJaePTR27sfK5MfHrHG2DsQpmg6g== X-Received: by 2002:a05:6808:1814:b0:32b:851:35d5 with SMTP id bh20-20020a056808181400b0032b085135d5mr4002282oib.206.1653165474325; Sat, 21 May 2022 13:37:54 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s11-20020a9d58cb000000b006060322127bsm2388730oth.75.2022.05.21.13.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 13:37:53 -0700 (PDT) From: Tom Rix To: gregory.greenman@intel.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, luciano.coelho@intel.com, miriam.rachel.korenblit@intel.com, johannes.berg@intel.com, quic_srirrama@quicinc.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] iwlwifi: mvm: remove setting of 'sta' parameter Date: Sat, 21 May 2022 16:37:46 -0400 Message-Id: <20220521203746.442924-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org cppcheck reports [drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2686]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? The setting of the 'sta' parameter is not needed. In the if-check that sets it to NULL, mvm_sta is also set to NULL. Then the next statement checks if mvm_sta is NULL and does an early return. So remove setting sta. Signed-off-by: Tom Rix --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index 974eeecc9153..d75e3024ae3d 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -2683,7 +2683,6 @@ static void rs_drv_get_rate(void *mvm_r, struct ieee80211_sta *sta, /* if vif isn't initialized mvm doesn't know about * this station, so don't do anything with the it */ - sta = NULL; mvm_sta = NULL; }