diff mbox series

[v2,linux-next] wifi: wilc1000: remove redundant ret variable

Message ID 20220830105505.287564-1-cui.jinpeng2@zte.com.cn (mailing list archive)
State Accepted
Commit 1dc13236ef9171a00168452d93ca70682c45ad30
Delegated to: Kalle Valo
Headers show
Series [v2,linux-next] wifi: wilc1000: remove redundant ret variable | expand

Commit Message

CGEL Aug. 30, 2022, 10:55 a.m. UTC
From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>

Return value from cfg80211_rx_mgmt() directly instead of
taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
 drivers/net/wireless/microchip/wilc1000/cfg80211.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Kalle Valo Sept. 2, 2022, 8:46 a.m. UTC | #1
cgel.zte@gmail.com wrote:

> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> Return value from cfg80211_rx_mgmt() directly instead of
> taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>

Patch applied to wireless-next.git, thanks.

1dc13236ef91 wifi: wilc1000: remove redundant ret variable
diff mbox series

Patch

diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
index f810a56a7ff0..b89047965e78 100644
--- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c
+++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
@@ -997,12 +997,11 @@  bool wilc_wfi_mgmt_frame_rx(struct wilc_vif *vif, u8 *buff, u32 size)
 {
 	struct wilc *wl = vif->wilc;
 	struct wilc_priv *priv = &vif->priv;
-	int freq, ret;
+	int freq;
 
 	freq = ieee80211_channel_to_frequency(wl->op_ch, NL80211_BAND_2GHZ);
-	ret = cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0);
 
-	return ret;
+	return cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0);
 }
 
 void wilc_wfi_p2p_rx(struct wilc_vif *vif, u8 *buff, u32 size)