| Message ID | 20221006192051.1742930-1-keescook@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2577a58df24417dcdd35a3ba5b9e4e419a7d1234 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: carl9170: Remove -Warray-bounds exception | expand |
On 06/10/2022 21:20, Kees Cook wrote: > GCC-12 emits false positive -Warray-bounds warnings with > CONFIG_UBSAN_SHIFT (-fsanitize=shift). This is fixed in GCC 13[1], > and there is top-level Makefile logic to remove -Warray-bounds for > known-bad GCC versions staring with commit f0be87c42cbd ("gcc-12: disable > '-Warray-bounds' universally for now"). > > Remove the local work-around. > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105679 > > Signed-off-by: Kees Cook <keescook@chromium.org> Acked-by: Christian Lamparter <chunkeey@gmail.com>
Kees Cook <keescook@chromium.org> wrote: > GCC-12 emits false positive -Warray-bounds warnings with > CONFIG_UBSAN_SHIFT (-fsanitize=shift). This is fixed in GCC 13[1], > and there is top-level Makefile logic to remove -Warray-bounds for > known-bad GCC versions staring with commit f0be87c42cbd ("gcc-12: disable > '-Warray-bounds' universally for now"). > > Remove the local work-around. > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105679 > > Signed-off-by: Kees Cook <keescook@chromium.org> > Acked-by: Christian Lamparter <chunkeey@gmail.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 2577a58df244 wifi: carl9170: Remove -Warray-bounds exception
diff --git a/drivers/net/wireless/ath/carl9170/Makefile b/drivers/net/wireless/ath/carl9170/Makefile index 7463baa62fa8..1a81868ce26d 100644 --- a/drivers/net/wireless/ath/carl9170/Makefile +++ b/drivers/net/wireless/ath/carl9170/Makefile @@ -3,8 +3,3 @@ carl9170-objs := main.o usb.o cmd.o mac.o phy.o led.o fw.o tx.o rx.o carl9170-$(CONFIG_CARL9170_DEBUGFS) += debug.o obj-$(CONFIG_CARL9170) += carl9170.o - -# FIXME: temporarily silence -Warray-bounds on non W=1+ builds -ifndef KBUILD_EXTRA_WARN -CFLAGS_cmd.o += -Wno-array-bounds -endif
GCC-12 emits false positive -Warray-bounds warnings with CONFIG_UBSAN_SHIFT (-fsanitize=shift). This is fixed in GCC 13[1], and there is top-level Makefile logic to remove -Warray-bounds for known-bad GCC versions staring with commit f0be87c42cbd ("gcc-12: disable '-Warray-bounds' universally for now"). Remove the local work-around. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105679 Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/net/wireless/ath/carl9170/Makefile | 5 ----- 1 file changed, 5 deletions(-)