| Message ID | 20230416-brcmfmac-noise-v1-2-f0624e408761@marcan.st (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcmfmac: Demote some kernel errors to info | expand |
Hector Martin <marcan@marcan.st> writes: > This one is also spooking people when they see it in their boot console. > It's not fatal, so it shouldn't really be a noisy error. > > Fixes: 18e2f61db3b7 ("brcmfmac: P2P action frame tx.") > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > index d4492d02e4ea..071b0706d137 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c > @@ -1793,8 +1793,8 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg, > /* do not configure anything. it will be */ > /* sent with a default configuration */ > } else { > - bphy_err(drvr, "Unknown Frame: category 0x%x, action 0x%x\n", > - category, action); > + bphy_info_once(drvr, "Unknown Frame: category 0x%x, action 0x%x\n", > + category, action); > return false; > } What about changing this to a debug message so that it's not shown at all in normal operation? I don't see what value this message gives to a user.
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index d4492d02e4ea..071b0706d137 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -1793,8 +1793,8 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg, /* do not configure anything. it will be */ /* sent with a default configuration */ } else { - bphy_err(drvr, "Unknown Frame: category 0x%x, action 0x%x\n", - category, action); + bphy_info_once(drvr, "Unknown Frame: category 0x%x, action 0x%x\n", + category, action); return false; }
This one is also spooking people when they see it in their boot console. It's not fatal, so it shouldn't really be a noisy error. Fixes: 18e2f61db3b7 ("brcmfmac: P2P action frame tx.") Signed-off-by: Hector Martin <marcan@marcan.st> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)