| Message ID | 20230601082556.2738446-3-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fad5ac80dfa5010d44c24d59d9e8e1552a447911 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Convert to platform remove callback returning void | expand |
On Thu, Jun 01, 2023 at 10:25:54AM +0200, Uwe Kleine-König wrote: > platform_get_drvdata() cannot return NULL as the probe function calls > platform_set_drvdata() with a non-NULL argument or returns with a failure. > In the first case, platform_get_drvdata() returns this non-NULL value and > in the second the remove callback isn't called at all. > > ath10k_ahb_priv() cannot return NULL and ar_ahb is unused after the check > anyhow. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Simon Horman <simon.horman@corigine.com>
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c index 7bb45c66cff7..fffdbad75074 100644 --- a/drivers/net/wireless/ath/ath10k/ahb.c +++ b/drivers/net/wireless/ath/ath10k/ahb.c @@ -823,15 +823,6 @@ static int ath10k_ahb_probe(struct platform_device *pdev) static int ath10k_ahb_remove(struct platform_device *pdev) { struct ath10k *ar = platform_get_drvdata(pdev); - struct ath10k_ahb *ar_ahb; - - if (!ar) - return -EINVAL; - - ar_ahb = ath10k_ahb_priv(ar); - - if (!ar_ahb) - return -EINVAL; ath10k_dbg(ar, ATH10K_DBG_AHB, "ahb remove\n");
platform_get_drvdata() cannot return NULL as the probe function calls platform_set_drvdata() with a non-NULL argument or returns with a failure. In the first case, platform_get_drvdata() returns this non-NULL value and in the second the remove callback isn't called at all. ath10k_ahb_priv() cannot return NULL and ar_ahb is unused after the check anyhow. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/net/wireless/ath/ath10k/ahb.c | 9 --------- 1 file changed, 9 deletions(-)