| Message ID | 20230713082433.11485-1-duminjie@vivo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v4] wifi: ath5k: remove parameter check in ath5k_debug_init_device() | expand |
On 13. 07. 23, 14:30, Markus Elfring wrote:
> Please apply the subject “[PATCH v5] wifi: ath5k: Remove an error check in ath5k_debug_init_device()”.
FWIW I personally prefer the European style: lowercase after colon. So I
would not suggest anyone to use one or the other.
On 14. 07. 23, 8:00, Markus Elfring wrote: >>> Please apply the subject “[PATCH v5] wifi: ath5k: Remove an error check in ath5k_debug_init_device()”. >> >> FWIW I personally prefer the European style: lowercase after colon. So I would not suggest anyone to use one or the other. > > How do you think about to achieve any further clarifications also according to > the removal / deletion for items like the following? > > * error > > * parameter > > * variable Sorry, I don't follow.
On 13. 07. 23, 10:24, Minjie Du wrote: > The parameter 'phydir' error check is mistake. It's not actually a parameter. > debugfs_create_file() will return early if 'phydir' is an error pointer, > so the error check is removed. What about something like: Subject: wifi: ath5k: remove phydir check from ath5k_debug_init_device() 'phydir' returned from debugfs_create_dir() is checked against NULL. As the debugfs API returns an error pointer, the returned value can never be NULL. So instead, remove the check completely as it is unneeded as per documentation. (Other debugfs calls are a nop in the error case.) ? Or something like that, feel free to reword. > Signed-off-by: Minjie Du <duminjie@vivo.com> > --- > v1: use IS_ERR() to error check. > v2: use IS_ERR_OR_NULL() to error check. > v3: remove the error check. > v4: fix the patch format. > --- > drivers/net/wireless/ath/ath5k/debug.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c > index 4b41160e5..ec130510a 100644 > --- a/drivers/net/wireless/ath/ath5k/debug.c > +++ b/drivers/net/wireless/ath/ath5k/debug.c > @@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah) > ah->debug.level = ath5k_debug; > > phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir); > - if (!phydir) > - return; > > debugfs_create_file("debug", 0600, phydir, ah, &fops_debug); > debugfs_create_file("registers", 0400, phydir, ah, ®isters_fops);
diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c index 4b41160e5..ec130510a 100644 --- a/drivers/net/wireless/ath/ath5k/debug.c +++ b/drivers/net/wireless/ath/ath5k/debug.c @@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah) ah->debug.level = ath5k_debug; phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir); - if (!phydir) - return; debugfs_create_file("debug", 0600, phydir, ah, &fops_debug); debugfs_create_file("registers", 0400, phydir, ah, ®isters_fops);
The parameter 'phydir' error check is mistake. debugfs_create_file() will return early if 'phydir' is an error pointer, so the error check is removed. Signed-off-by: Minjie Du <duminjie@vivo.com> --- v1: use IS_ERR() to error check. v2: use IS_ERR_OR_NULL() to error check. v3: remove the error check. v4: fix the patch format. --- drivers/net/wireless/ath/ath5k/debug.c | 2 -- 1 file changed, 2 deletions(-)