| Message ID | 20230714001126.463127-1-arowa@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4a93b554cf9fa64faa7cf164c0d32fc3ce67108b |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v4] wifi: ath11k: Add crash logging | expand |
On 7/13/2023 5:10 PM, Arowa Suliman wrote: > Currently, the ath11k driver does not print a crash signature when a > crash happens. Checked by triggering a simulated crash using the command > [1] and checking dmesg for logs. > > [1] echo assert > /sys/kernel/debug/ath11k/../simulate_fw_crash > > Change the crash logging from debug to informational and add a warning > when firmware crash MHI_CB_EE_RDDM happens. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 > > Signed-off-by: Arowa Suliman <arowa@chromium.org> Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Arowa Suliman <arowa@chromium.org> writes: > Currently, the ath11k driver does not print a crash signature when a > crash happens. Checked by triggering a simulated crash using the command > [1] and checking dmesg for logs. > > [1] echo assert > /sys/kernel/debug/ath11k/../simulate_fw_crash > > Change the crash logging from debug to informational and add a warning > when firmware crash MHI_CB_EE_RDDM happens. > > Tested-on: WCN6855 hw2.0 PCI > WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 > > Signed-off-by: Arowa Suliman <arowa@chromium.org> I did some cosmetic cleanup to the commit log. > --- a/drivers/net/wireless/ath/ath11k/mhi.c > +++ b/drivers/net/wireless/ath/ath11k/mhi.c > @@ -325,14 +325,15 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl, > { > struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev); > > - ath11k_dbg(ab, ATH11K_DBG_BOOT, "notify status reason %s\n", > - ath11k_mhi_op_callback_to_str(cb)); > + ath11k_info(ab, "notify status reason %s\n", > + ath11k_mhi_op_callback_to_str(cb)); In my view info, warning and error messages need to be at least somewhat understandable to the user. I think this message is not understandable and it should remain as a debug message. So I removed this change. Please check my changes in the pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f9325b14e830f3e8b5a557352e7c65f321bb7b05
Arowa Suliman <arowa@chromium.org> wrote: > Currently, the ath11k driver does not print a crash signature when a > MHI_CB_EE_RDDM crash happens. Checked by triggering a simulated crash using the > command and checking dmesg for logs: > > echo assert > /sys/kernel/debug/ath11k/../simulate_fw_crash > > Add a warning when firmware crash MHI_CB_EE_RDDM happens. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 > > Signed-off-by: Arowa Suliman <arowa@chromium.org> > Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 4a93b554cf9f wifi: ath11k: mhi: add a warning message for MHI_CB_EE_RDDM crash
diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c index 3ac689f1def4..025fa58b1503 100644 --- a/drivers/net/wireless/ath/ath11k/mhi.c +++ b/drivers/net/wireless/ath/ath11k/mhi.c @@ -325,14 +325,15 @@ static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl, { struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev); - ath11k_dbg(ab, ATH11K_DBG_BOOT, "notify status reason %s\n", - ath11k_mhi_op_callback_to_str(cb)); + ath11k_info(ab, "notify status reason %s\n", + ath11k_mhi_op_callback_to_str(cb)); switch (cb) { case MHI_CB_SYS_ERROR: ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n"); break; case MHI_CB_EE_RDDM: + ath11k_warn(ab, "firmware crashed: MHI_CB_EE_RDDM\n"); if (!(test_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags))) queue_work(ab->workqueue_aux, &ab->reset_work); break;
Currently, the ath11k driver does not print a crash signature when a crash happens. Checked by triggering a simulated crash using the command [1] and checking dmesg for logs. [1] echo assert > /sys/kernel/debug/ath11k/../simulate_fw_crash Change the crash logging from debug to informational and add a warning when firmware crash MHI_CB_EE_RDDM happens. Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 Signed-off-by: Arowa Suliman <arowa@chromium.org> --- v4: Shift line 329 one space to the right to fix code alignment. --- drivers/net/wireless/ath/ath11k/mhi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)