| Message ID | 20230714071002.1264-1-duminjie@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v5] wifi: ath5k: remove phydir check from ath5k_debug_init_device() | expand |
On 14. 07. 23, 9:10, Minjie Du wrote: > 'phydir' returned from debugfs_create_dir() is checked against NULL. > As the debugfs API returns an error pointer, > the returned value can never be NULL. > > Therefore, as the documentation suggests that the check is unnecessary > and other debugfs calls have no operation in error cases, > it is advisable to completely eliminate the check. > > Signed-off-by: Minjie Du <duminjie@vivo.com> Reviewed-by: Jiri Slaby <jirislaby@kernel.org> thanks,
diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c index 4b41160e5..ec130510a 100644 --- a/drivers/net/wireless/ath/ath5k/debug.c +++ b/drivers/net/wireless/ath/ath5k/debug.c @@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah) ah->debug.level = ath5k_debug; phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir); - if (!phydir) - return; debugfs_create_file("debug", 0600, phydir, ah, &fops_debug); debugfs_create_file("registers", 0400, phydir, ah, ®isters_fops);
'phydir' returned from debugfs_create_dir() is checked against NULL. As the debugfs API returns an error pointer, the returned value can never be NULL. Therefore, as the documentation suggests that the check is unnecessary and other debugfs calls have no operation in error cases, it is advisable to completely eliminate the check. Signed-off-by: Minjie Du <duminjie@vivo.com> --- V4 -> V5: fix expression about patch. V3 -> V4: fix the patch format. V2 -> V3: remove the error check. V1 -> V2: use IS_ERR_OR_NULL() replace IS_ERR() to error check. V1: use IS_ERR() to error check. --- drivers/net/wireless/ath/ath5k/debug.c | 2 -- 1 file changed, 2 deletions(-)