diff mbox series

iw: connect: Fix segfault during open authentication

Message ID 20230726192245.100897-1-Chaitanya.Tata@nordicsemi.no (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series iw: connect: Fix segfault during open authentication | expand

Commit Message

Krishna Chaitanya July 26, 2023, 7:22 p.m. UTC 
The check for remaining arguments is done after decrement effectively
bypassing the non-zero check and causes a segfault with below command:

  "connect <SSID> auth open/shared".

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
---
 connect.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/connect.c b/connect.c
index e5b177f..33e1a5f 100644
--- a/connect.c
+++ b/connect.c
@@ -77,6 +77,9 @@  static int iw_conn(struct nl80211_state *state,
 	if (argc && strcmp(*argv, "key") != 0 && strcmp(*argv, "keys") != 0)
 		return 1;
 
+	if (!argc)
+		return 0;
+
 	argv++;
 	argc--;