| Message ID | 20230731140712.1204-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | mac80211: mesh: Remove unused function declaration mesh_ids_set_default() | expand |
Yue Haibing <yuehaibing@huawei.com> writes: > Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") > introducted this but never implemented. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > net/mac80211/mesh.h | 1 - > 1 file changed, 1 deletion(-) The title should have "wifi:" but no need to resend because of this.
On Mon, Jul 31, 2023 at 10:07:12PM +0800, Yue Haibing wrote: > Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") > introducted this but never implemented. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Mon, 2023-07-31 at 22:07 +0800, Yue Haibing wrote: > Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") > introducted this but never implemented. > Btw, are you detecting these with some kind of tool? Having the tool would probably be more useful than you sending all these patches all the time ... johannes
On 2023/8/8 16:24, Johannes Berg wrote: > On Mon, 2023-07-31 at 22:07 +0800, Yue Haibing wrote: >> Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") >> introducted this but never implemented. >> > > Btw, are you detecting these with some kind of tool? Having the tool > would probably be more useful than you sending all these patches all the > time ... > Just use grep to check like below grep -rP --include=*.c '^(?:\w+\s+){1,3}\*{0,3}\s{0,3}\w+[\t]*\(' * |grep -P -oh '\w+\s*\('|sort| uniq -c| sort -n| grep -P '^\s+1\b'|sed -r -e 's/^\s+1\s+//' -e 's/\(//'|while read line ; do IS=`git grep -w $line |wc -l` ; if [ $IS -eq 1 ];then git grep -wn $line fi done > johannes > . >
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h index 6c94222a9df5..ad8469293d71 100644 --- a/net/mac80211/mesh.h +++ b/net/mac80211/mesh.h @@ -212,7 +212,6 @@ int mesh_rmc_check(struct ieee80211_sub_if_data *sdata, const u8 *addr, struct ieee80211s_hdr *mesh_hdr); bool mesh_matches_local(struct ieee80211_sub_if_data *sdata, struct ieee802_11_elems *ie); -void mesh_ids_set_default(struct ieee80211_if_mesh *mesh); int mesh_add_meshconf_ie(struct ieee80211_sub_if_data *sdata, struct sk_buff *skb); int mesh_add_meshid_ie(struct ieee80211_sub_if_data *sdata,
Commit ccf80ddfe492 ("mac80211: mesh function and data structures definitions") introducted this but never implemented. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- net/mac80211/mesh.h | 1 - 1 file changed, 1 deletion(-)