| Message ID | 20230810091224.70088-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | de43b07db2a1af0d11ed167bb028f1038ae04086 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [net-next,1/2] wifi: ath11k: fix Wvoid-pointer-to-enum-cast warning | expand |
On 8/10/2023 2:12 AM, Krzysztof Kozlowski wrote: > 'hw_rev' is an enum, thus cast of pointer on 64-bit compile test with W=1 > causes: > > ath10k/ahb.c:736:11: error: cast to smaller integer type 'enum ath10k_hw_rev' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/net/wireless/ath/ath10k/ahb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c > index 4a006fb4d424..95bcf54ddc3f 100644 > --- a/drivers/net/wireless/ath/ath10k/ahb.c > +++ b/drivers/net/wireless/ath/ath10k/ahb.c > @@ -733,7 +733,7 @@ static int ath10k_ahb_probe(struct platform_device *pdev) > int ret; > struct ath10k_bus_params bus_params = {}; > > - hw_rev = (enum ath10k_hw_rev)of_device_get_match_data(&pdev->dev); > + hw_rev = (uintptr_t)of_device_get_match_data(&pdev->dev); > if (!hw_rev) { > dev_err(&pdev->dev, "OF data missing\n"); > return -EINVAL;
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c index 4a006fb4d424..95bcf54ddc3f 100644 --- a/drivers/net/wireless/ath/ath10k/ahb.c +++ b/drivers/net/wireless/ath/ath10k/ahb.c @@ -733,7 +733,7 @@ static int ath10k_ahb_probe(struct platform_device *pdev) int ret; struct ath10k_bus_params bus_params = {}; - hw_rev = (enum ath10k_hw_rev)of_device_get_match_data(&pdev->dev); + hw_rev = (uintptr_t)of_device_get_match_data(&pdev->dev); if (!hw_rev) { dev_err(&pdev->dev, "OF data missing\n"); return -EINVAL;
'hw_rev' is an enum, thus cast of pointer on 64-bit compile test with W=1 causes: ath10k/ahb.c:736:11: error: cast to smaller integer type 'enum ath10k_hw_rev' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/net/wireless/ath/ath10k/ahb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)