| Message ID | 20230824062339.1885385-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e8afebbf434b7d7aede0122032ece40ae671bb44 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: rtl8723: Remove unused function rtl8723_cmd_send_packet() | expand |
> -----Original Message----- > From: Jinjie Ruan <ruanjinjie@huawei.com> > Sent: Thursday, August 24, 2023 2:24 PM > To: linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org> > Cc: ruanjinjie@huawei.com > Subject: [PATCH] rtlwifi: rtl8723: Remove unused function rtl8723_cmd_send_packet() Subject should be "wifi: ...." > > The function rtl8723_cmd_send_packet() is not used anywhere, so remove it. > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Others look good to me. Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Jinjie Ruan <ruanjinjie@huawei.com> wrote: > The function rtl8723_cmd_send_packet() is not used anywhere, so remove it. > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. e8afebbf434b wifi: rtlwifi: rtl8723: Remove unused function rtl8723_cmd_send_packet()
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c index 36c00b89ccae..50b79cf8fb3c 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.c @@ -215,31 +215,3 @@ int rtl8723_download_fw(struct ieee80211_hw *hw, } EXPORT_SYMBOL_GPL(rtl8723_download_fw); -bool rtl8723_cmd_send_packet(struct ieee80211_hw *hw, - struct sk_buff *skb) -{ - struct rtl_priv *rtlpriv = rtl_priv(hw); - struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); - struct rtl8192_tx_ring *ring; - struct rtl_tx_desc *pdesc; - struct sk_buff *pskb = NULL; - unsigned long flags; - - ring = &rtlpci->tx_ring[BEACON_QUEUE]; - - pskb = __skb_dequeue(&ring->queue); - kfree_skb(pskb); - spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags); - - pdesc = &ring->desc[0]; - rtlpriv->cfg->ops->fill_tx_cmddesc(hw, (u8 *)pdesc, 1, 1, skb); - - __skb_queue_tail(&ring->queue, skb); - - spin_unlock_irqrestore(&rtlpriv->locks.irq_th_lock, flags); - - rtlpriv->cfg->ops->tx_polling(hw, BEACON_QUEUE); - - return true; -} -EXPORT_SYMBOL_GPL(rtl8723_cmd_send_packet); diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.h b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.h index b527fcbbdf08..c8e04f9722ae 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.h +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723com/fw_common.h @@ -66,7 +66,5 @@ void rtl8723_write_fw(struct ieee80211_hw *hw, u8 *buffer, u32 size, u8 max_page); int rtl8723_fw_free_to_go(struct ieee80211_hw *hw, bool is_8723be, int count); int rtl8723_download_fw(struct ieee80211_hw *hw, bool is_8723be, int count); -bool rtl8723_cmd_send_packet(struct ieee80211_hw *hw, - struct sk_buff *skb); #endif
The function rtl8723_cmd_send_packet() is not used anywhere, so remove it. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- .../realtek/rtlwifi/rtl8723com/fw_common.c | 28 ------------------- .../realtek/rtlwifi/rtl8723com/fw_common.h | 2 -- 2 files changed, 30 deletions(-)