| Message ID | 20230903030216.1509013-3-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 50180c7f8e3de7c2d87f619131776598fcb1478d |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: Drop unnecessary error checks for debugfs_create_dir() | expand |
Jinjie Ruan <ruanjinjie@huawei.com> wrote: > debugfs_create_dir() returns ERR_PTR and never return NULL. > > As Russell suggested, this patch removes the error checking for > debugfs_create_dir(). This is because the DebugFS kernel API is developed > in a way that the caller can safely ignore the errors that occur during > the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in > start_creating() which can handle it gracefully. So these checks are > unnecessary. > > Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk> Patch applied to wireless-next.git, thanks. 50180c7f8e3d wifi: mwifiex: debugfs: Drop unnecessary error check for debugfs_create_dir()
diff --git a/drivers/net/wireless/marvell/mwifiex/debugfs.c b/drivers/net/wireless/marvell/mwifiex/debugfs.c index f9c9fec7c792..d14a0f4c1b6d 100644 --- a/drivers/net/wireless/marvell/mwifiex/debugfs.c +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c @@ -970,9 +970,6 @@ mwifiex_dev_debugfs_init(struct mwifiex_private *priv) priv->dfs_dev_dir = debugfs_create_dir(priv->netdev->name, mwifiex_dfs_dir); - if (!priv->dfs_dev_dir) - return; - MWIFIEX_DFS_ADD_FILE(info); MWIFIEX_DFS_ADD_FILE(debug); MWIFIEX_DFS_ADD_FILE(getlog);
debugfs_create_dir() returns ERR_PTR and never return NULL. As Russell suggested, this patch removes the error checking for debugfs_create_dir(). This is because the DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in start_creating() which can handle it gracefully. So these checks are unnecessary. Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk> --- v2: - Remove the err check instead of using IS_ERR to replace NULL check. - Update the commit message and title. --- drivers/net/wireless/marvell/mwifiex/debugfs.c | 3 --- 1 file changed, 3 deletions(-)