| Message ID | 20231009-ath11k_htc_frame-v1-1-81d405b7a195@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 480d230bef0ecd06e72ae3a84117142e38e77503 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath11k: Remove unused struct ath11k_htc_frame | expand |
Jeff Johnson <quic_jjohnson@quicinc.com> wrote: > struct ath11k_htc_frame is unused, and since it illogically contains > two consecutive flexible arrays, it could never be used, so remove it. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 480d230bef0e wifi: ath11k: Remove unused struct ath11k_htc_frame
diff --git a/drivers/net/wireless/ath/ath11k/htc.h b/drivers/net/wireless/ath/ath11k/htc.h index f429b37cfdf7..d31e501c807c 100644 --- a/drivers/net/wireless/ath/ath11k/htc.h +++ b/drivers/net/wireless/ath/ath11k/htc.h @@ -156,18 +156,6 @@ struct ath11k_htc_record { }; } __packed __aligned(4); -/* note: the trailer offset is dynamic depending - * on payload length. this is only a struct layout draft - */ -struct ath11k_htc_frame { - struct ath11k_htc_hdr hdr; - union { - struct ath11k_htc_msg msg; - u8 payload[0]; - }; - struct ath11k_htc_record trailer[0]; -} __packed __aligned(4); - enum ath11k_htc_svc_gid { ATH11K_HTC_SVC_GRP_RSVD = 0, ATH11K_HTC_SVC_GRP_WMI = 1,
struct ath11k_htc_frame is unused, and since it illogically contains two consecutive flexible arrays, it could never be used, so remove it. No functional changes, compile tested only. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/net/wireless/ath/ath11k/htc.h | 12 ------------ 1 file changed, 12 deletions(-) --- base-commit: 453a62a3ee65aeba6e69bfd09227fc2f19290bea change-id: 20231005-ath11k_htc_frame-f796cff00064