diff mbox series

ssb: relax SSB_EMBEDDED dependencies

Message ID 20231012220856.23260-1-rdunlap@infradead.org (mailing list archive)
State Accepted
Commit a86a8ca798e9c3037c04011c993a92c173fba0c2
Delegated to: Kalle Valo
Headers show
Series ssb: relax SSB_EMBEDDED dependencies | expand

Commit Message

Randy Dunlap Oct. 12, 2023, 10:08 p.m. UTC 
This is a kconfig warning in a randconfig when CONFIG_PCI is not set:

WARNING: unmet direct dependencies detected for SSB_EMBEDDED
  Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] && SSB_PCICORE_HOSTMODE [=n]
  Selected by [y]:
  - BCM47XX_SSB [=y] && BCM47XX [=y]

This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB
selecting SSB_EMBEDDED when CONFIG_PCI is not set.

This warning can be prevented by altering SSB_EMBEDDED to allow for
PCI=n or the former SSB_PCICORE_HOSTMODE.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Michael Büsch <m@bues.ch>
Cc: linux-wireless@vger.kernel.org
Cc: Kalle Valo <kvalo@kernel.org>
---
 drivers/ssb/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kalle Valo Oct. 19, 2023, 7:27 a.m. UTC | #1 
Randy Dunlap <rdunlap@infradead.org> wrote:

> This is a kconfig warning in a randconfig when CONFIG_PCI is not set:
> 
> WARNING: unmet direct dependencies detected for SSB_EMBEDDED
>   Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] && SSB_PCICORE_HOSTMODE [=n]
>   Selected by [y]:
>   - BCM47XX_SSB [=y] && BCM47XX [=y]
> 
> This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB
> selecting SSB_EMBEDDED when CONFIG_PCI is not set.
> 
> This warning can be prevented by altering SSB_EMBEDDED to allow for
> PCI=n or the former SSB_PCICORE_HOSTMODE.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Michael Büsch <m@bues.ch>
> Cc: linux-wireless@vger.kernel.org
> Cc: Kalle Valo <kvalo@kernel.org>

Patch applied to wireless-next.git, thanks.

a86a8ca798e9 ssb: relax SSB_EMBEDDED dependencies
diff mbox series

Patch

diff -- a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -134,7 +134,8 @@  config SSB_SFLASH
 # Assumption: We are on embedded, if we compile the MIPS core.
 config SSB_EMBEDDED
 	bool
-	depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE
+	depends on SSB_DRIVER_MIPS
+	depends on PCI=n || SSB_PCICORE_HOSTMODE
 	default y
 
 config SSB_DRIVER_EXTIF