| Message ID | 20231122083047.12774-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 18814f723f92826d83fef40e19fc8cb130367868 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: libertas: fix config name in dependency for SDIO support | expand |
On Wed, Nov 22, 2023, at 09:30, Lukas Bulwahn wrote: > Commit 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") reworks > the dependencies for config LIBERTAS, and adds alternative dependencies for > USB, SDIO and SPI. > > The config option SDIO however does not exist in the kernel tree. It was > probably intended to refer to the config option MMC, which represents > "MMC/SD/SDIO card support" and is used as dependency by various other > drivers that use SDIO. > > Fix the dependency to the config option MMC for declaring the requirement > on provision of SDIO support. > > Fixes: 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Good catch Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > Commit 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") reworks > the dependencies for config LIBERTAS, and adds alternative dependencies for > USB, SDIO and SPI. > > The config option SDIO however does not exist in the kernel tree. It was > probably intended to refer to the config option MMC, which represents > "MMC/SD/SDIO card support" and is used as dependency by various other > drivers that use SDIO. > > Fix the dependency to the config option MMC for declaring the requirement > on provision of SDIO support. > > Fixes: 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > Reviewed-by: Arnd Bergmann <arnd@arndb.de> Patch applied to wireless-next.git, thanks. 18814f723f92 wifi: libertas: fix config name in dependency for SDIO support
diff --git a/drivers/net/wireless/marvell/libertas/Kconfig b/drivers/net/wireless/marvell/libertas/Kconfig index 56156a021be3..36b234bc5be8 100644 --- a/drivers/net/wireless/marvell/libertas/Kconfig +++ b/drivers/net/wireless/marvell/libertas/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config LIBERTAS tristate "Marvell 8xxx Libertas WLAN driver support" - depends on USB || SDIO || SPI + depends on USB || MMC || SPI depends on CFG80211 select LIB80211 select FW_LOADER
Commit 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") reworks the dependencies for config LIBERTAS, and adds alternative dependencies for USB, SDIO and SPI. The config option SDIO however does not exist in the kernel tree. It was probably intended to refer to the config option MMC, which represents "MMC/SD/SDIO card support" and is used as dependency by various other drivers that use SDIO. Fix the dependency to the config option MMC for declaring the requirement on provision of SDIO support. Fixes: 4b478bf6bdd8 ("wifi: libertas: drop 16-bit PCMCIA support") Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- drivers/net/wireless/marvell/libertas/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)