diff mbox series

[RFC,v2,4/8] wifi: ath11k: remove MHI LOOPBACK channels

Message ID 20231127162022.518834-5-kvalo@kernel.org (mailing list archive)
State RFC
Delegated to: Kalle Valo
Headers show
Series wifi: ath11k: hibernation support | expand

Commit Message

Kalle Valo Nov. 27, 2023, 4:20 p.m. UTC 
From: Baochen Qiang <quic_bqiang@quicinc.com>

There is no driver to match these two channels, so
remove them. This fixes warnings from MHI subsystem during suspend:

mhi mhi0_LOOPBACK: 1: Failed to reset channel, still resetting
mhi mhi0_LOOPBACK: 0: Failed to reset channel, still resetting

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30

Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
---
 drivers/net/wireless/ath/ath11k/mhi.c | 56 ---------------------------
 1 file changed, 56 deletions(-)

Comments

Baochen Qiang Nov. 28, 2023, 1:13 a.m. UTC | #1 
On 11/28/2023 12:20 AM, Kalle Valo wrote:
> From: Baochen Qiang <quic_bqiang@quicinc.com>
> 
> There is no driver to match these two channels, so
> remove them. This fixes warnings from MHI subsystem during suspend:
> 
> mhi mhi0_LOOPBACK: 1: Failed to reset channel, still resetting
> mhi mhi0_LOOPBACK: 0: Failed to reset channel, still resetting
With v2, these warnings are gone even without this patch. so it should 
be removed from commit log. It's enough to only mention that those 
channels are not used.

> 
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
> 
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
>   drivers/net/wireless/ath/ath11k/mhi.c | 56 ---------------------------
>   1 file changed, 56 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
> index afeabd6ecc67..579af57f7377 100644
> --- a/drivers/net/wireless/ath/ath11k/mhi.c
> +++ b/drivers/net/wireless/ath/ath11k/mhi.c
> @@ -21,34 +21,6 @@
>   #define RDDM_DUMP_SIZE	0x420000
>   
>   static struct mhi_channel_config ath11k_mhi_channels_qca6390[] = {
> -	{
> -		.num = 0,
> -		.name = "LOOPBACK",
> -		.num_elements = 32,
> -		.event_ring = 0,
> -		.dir = DMA_TO_DEVICE,
> -		.ee_mask = 0x4,
> -		.pollcfg = 0,
> -		.doorbell = MHI_DB_BRST_DISABLE,
> -		.lpm_notify = false,
> -		.offload_channel = false,
> -		.doorbell_mode_switch = false,
> -		.auto_queue = false,
> -	},
> -	{
> -		.num = 1,
> -		.name = "LOOPBACK",
> -		.num_elements = 32,
> -		.event_ring = 0,
> -		.dir = DMA_FROM_DEVICE,
> -		.ee_mask = 0x4,
> -		.pollcfg = 0,
> -		.doorbell = MHI_DB_BRST_DISABLE,
> -		.lpm_notify = false,
> -		.offload_channel = false,
> -		.doorbell_mode_switch = false,
> -		.auto_queue = false,
> -	},
>   	{
>   		.num = 20,
>   		.name = "IPCR",
> @@ -114,34 +86,6 @@ static struct mhi_controller_config ath11k_mhi_config_qca6390 = {
>   };
>   
>   static struct mhi_channel_config ath11k_mhi_channels_qcn9074[] = {
> -	{
> -		.num = 0,
> -		.name = "LOOPBACK",
> -		.num_elements = 32,
> -		.event_ring = 1,
> -		.dir = DMA_TO_DEVICE,
> -		.ee_mask = 0x14,
> -		.pollcfg = 0,
> -		.doorbell = MHI_DB_BRST_DISABLE,
> -		.lpm_notify = false,
> -		.offload_channel = false,
> -		.doorbell_mode_switch = false,
> -		.auto_queue = false,
> -	},
> -	{
> -		.num = 1,
> -		.name = "LOOPBACK",
> -		.num_elements = 32,
> -		.event_ring = 1,
> -		.dir = DMA_FROM_DEVICE,
> -		.ee_mask = 0x14,
> -		.pollcfg = 0,
> -		.doorbell = MHI_DB_BRST_DISABLE,
> -		.lpm_notify = false,
> -		.offload_channel = false,
> -		.doorbell_mode_switch = false,
> -		.auto_queue = false,
> -	},
>   	{
>   		.num = 20,
>   		.name = "IPCR",
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mhi.c b/drivers/net/wireless/ath/ath11k/mhi.c
index afeabd6ecc67..579af57f7377 100644
--- a/drivers/net/wireless/ath/ath11k/mhi.c
+++ b/drivers/net/wireless/ath/ath11k/mhi.c
@@ -21,34 +21,6 @@ 
 #define RDDM_DUMP_SIZE	0x420000
 
 static struct mhi_channel_config ath11k_mhi_channels_qca6390[] = {
-	{
-		.num = 0,
-		.name = "LOOPBACK",
-		.num_elements = 32,
-		.event_ring = 0,
-		.dir = DMA_TO_DEVICE,
-		.ee_mask = 0x4,
-		.pollcfg = 0,
-		.doorbell = MHI_DB_BRST_DISABLE,
-		.lpm_notify = false,
-		.offload_channel = false,
-		.doorbell_mode_switch = false,
-		.auto_queue = false,
-	},
-	{
-		.num = 1,
-		.name = "LOOPBACK",
-		.num_elements = 32,
-		.event_ring = 0,
-		.dir = DMA_FROM_DEVICE,
-		.ee_mask = 0x4,
-		.pollcfg = 0,
-		.doorbell = MHI_DB_BRST_DISABLE,
-		.lpm_notify = false,
-		.offload_channel = false,
-		.doorbell_mode_switch = false,
-		.auto_queue = false,
-	},
 	{
 		.num = 20,
 		.name = "IPCR",
@@ -114,34 +86,6 @@  static struct mhi_controller_config ath11k_mhi_config_qca6390 = {
 };
 
 static struct mhi_channel_config ath11k_mhi_channels_qcn9074[] = {
-	{
-		.num = 0,
-		.name = "LOOPBACK",
-		.num_elements = 32,
-		.event_ring = 1,
-		.dir = DMA_TO_DEVICE,
-		.ee_mask = 0x14,
-		.pollcfg = 0,
-		.doorbell = MHI_DB_BRST_DISABLE,
-		.lpm_notify = false,
-		.offload_channel = false,
-		.doorbell_mode_switch = false,
-		.auto_queue = false,
-	},
-	{
-		.num = 1,
-		.name = "LOOPBACK",
-		.num_elements = 32,
-		.event_ring = 1,
-		.dir = DMA_FROM_DEVICE,
-		.ee_mask = 0x14,
-		.pollcfg = 0,
-		.doorbell = MHI_DB_BRST_DISABLE,
-		.lpm_notify = false,
-		.offload_channel = false,
-		.doorbell_mode_switch = false,
-		.auto_queue = false,
-	},
 	{
 		.num = 20,
 		.name = "IPCR",